Date: Sat, 15 Jun 2013 16:50:15 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, bapt <bapt@etoilbsd.net>, bapt <baptiste.daroussin@gmail.com>, ports-committers@freebsd.org Subject: Re: RE : Re: svn commit: r320973 - head/audio/grip Message-ID: <20130615145014.GH72830@ithaqua.etoilebsd.net> In-Reply-To: <51BC3F88.4060706@passap.ru> References: <kqcoep27lv3xn9u9fa53omnt.1371285299440@email.android.com> <51BC2E7E.8030605@passap.ru> <20130615092043.GA47945@FreeBSD.org> <51BC3F88.4060706@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--BXr400anF0jyguTS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 15, 2013 at 02:18:48PM +0400, Boris Samorodov wrote: > 15.06.2013 13:20, Alexey Dokuchaev =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Sat, Jun 15, 2013 at 01:06:06PM +0400, Boris Samorodov wrote: > >> The shlib ABI version was removed from LIB_DEPENDS and it was not > >> reflected at the log. So the question arises if it was intended. > >> Imho (yep, it's really imho) this change is serious enough to go > >> to the log. > >=20 > > While I support you here on necessity of documenting every change in the > > commit log, dropping ABI versions from LIB_DEPENDS had been common prac= tice > > for a while now, and can be forgiven. >=20 > ----- > LIB_DEPENDS=3D id3-3.8.3:${PORTSDIR}/audio/id3lib \ > - curl.6:${PORTSDIR}/ftp/curl > + curl:${PORTSDIR}/ftp/curl > ----- >=20 > Well, I'm not sure if the change was intended and it was not > documented. Hence my question. And why curl was changed while > id3 -- not? (BTW it's just a rhetoric question) I removed the shlib for curl because is it safe and I didn't for id3 becaus= e it will hit the buggy LIB_DEPENDS I'm speaking in my previous CFT mail. id3-3.8 will match libid3-3.so.8 and libid3-3.8.so so I kept the shlib numb= er. >=20 > I don't blame Baptiste. I was just curious if that change was intended. > And as a side note, if that change was logged, the question wouldn't > occur. As simple as that. I don't feel blamed and I do like reviews and questions, that allows to dou= ble check something done is right or wrong :). >=20 > > We have much worse examples of > > commits documented with one-liner log (which is bogus most of the times= ); > > now, *that* is a problem. :( >=20 > +1 :-( Agree I will try to improve my commit logs. >=20 > >> Second, the package definitely had changed. The dependency had > >> changed from libcurl.so.6 to libcurl.so. And this is recorded > >> at the package. > >=20 > > I didn't know we're recording fully expanded shlibs in +CONTENTS. Libr= ary > > versions are recorded inside the binaries, >=20 > Yes, that means that a package (one or more binaries) has changed. No this information is only concerning the package neither the binary, it i= s a port framework only information. >=20 > > but in this case, dropping them > > from LIB_DEPENDS should be no-op. >=20 > Is it because the dependency is more wide? If yes, than thanks, I need > just this information: "It is not a significant change for the package." This change gives exactly no change at all to the generated package neither= to the binary. regards, Bapt --BXr400anF0jyguTS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG8fyYACgkQ8kTtMUmk6EyfRwCfdZazYnCt7CbIsNDoVS0aLtw+ okkAn1gs/YRUyY+7CkXmQBp65m1ReiI8 =iE19 -----END PGP SIGNATURE----- --BXr400anF0jyguTS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130615145014.GH72830>