From owner-svn-ports-head@freebsd.org Sat Oct 17 21:37:34 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5E11A17A7A for ; Sat, 17 Oct 2015 21:37:34 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7EE3F185B for ; Sat, 17 Oct 2015 21:37:34 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: (qmail 84334 invoked by uid 89); 17 Oct 2015 21:37:27 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 17 Oct 2015 21:37:27 -0000 Received: (qmail 84265 invoked by uid 89); 17 Oct 2015 21:37:10 -0000 Received: by simscan 1.3.1 ppid: 84260, pid: 84262, t: 0.0038s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 17 Oct 2015 21:37:10 -0000 Received: (qmail 516 invoked by uid 89); 17 Oct 2015 21:37:10 -0000 Received: by simscan 1.4.0 ppid: 481, pid: 508, t: 1.0165s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 17 Oct 2015 21:37:09 -0000 From: Jan Beich To: Kurt Jaeger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r399543 - in head/net: . openbsc openbsc/files References: <201510171655.t9HGtWH0004537@repo.freebsd.org> Date: Sat, 17 Oct 2015 23:36:53 +0200 In-Reply-To: <201510171655.t9HGtWH0004537@repo.freebsd.org> (Kurt Jaeger's message of "Sat, 17 Oct 2015 16:55:32 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2015 21:37:35 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kurt Jaeger writes: > +USES=3D autoreconf compiler:c11 gmake pkgconfig USES=3Dautoreconf often wants INSTALL_TARGET=3Dinstall-strip which is a standard automake target. > +GNU_CONFIGURE=3Dyes Missing indentation between =3D and the value? > +AUTOMAKE_ARGS=3D --gnu --add-missing --copy USE_AUTOTOOLS vestige? > +CONFIGURE_ARGS+=3D CFLAGS=3D"-I${LOCALBASE}/include" This overrides local CFLAGS, even defaults provided by sys.mk. Ironically, ports-mgmt/portlint only complains about _ENV not _ARGS but the rationale applies to both. WARN: Makefile: CFLAGS/CXXFLAGS are not needed in CONFIGURE_ENV as they a= re already added there in bsd.port.mk. WARN: Makefile: Consider passing include paths to configure via the CPPFL= AGS macro (i.e. CPPFLAGS+=3D-I...) FATAL: Makefile: CFLAGS are clobbered in CONFIGURE_ENV. Alter CFLAGS in = the Makefile with CFLAGS+=3D... instead > +OPTIONS_DEFAULT=3D Why empty? > +SQLITE_LIB_DEPENDS=3D libsqlite.so:${PORTSDIR}/databases/sqlite3 How does one disable SQLITE if libsqlite3.so is already installed? > +post-patch: > + ${REINPLACE_CMD} -e 's|pkgconfigdir.*|pkgconfigdir =3D ${PREFIX}/libdat= a/pkgconfig|g' \ > + ${WRKSRC}/Makefile.am Why not the following? USES =3D pathfix PATHFIX_MAKEFILEIN =3D Makefile.am > ++++ include/openbsc/mgcp.h > +@@ -31,6 +31,11 @@ > +=20 > + #include > +=20 > ++#ifdef __FreeBSD__ > ++#include > ++#include > ++#endif Why include only *some* POSIX headers conditionally? > ++++ include/openbsc/rtp.h > +@@ -10,6 +10,12 @@ > + # define __BYTE_ORDER __DARWIN_BYTE_ORDER > + # define __LITTLE_ENDIAN __DARWIN_LITTLE_ENDIAN > + # define __BIG_ENDIAN __DARWIN_BIG_ENDIAN > ++# elif defined(__FreeBSD__) > ++# if __FreeBSD_version < 1000000 > ++# include > ++# else > ++# include > ++# endif These headers aren't supposed to be included directly, see byteorder(9). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJWIr92XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bnTEH/AmZMUcViZoXo/u/dQrI2GHD dCPdrrka2xBkPdwnOMrChNVc8t+8nrhPPb3bJOu5RVFDKdjkXa/Wp4Si8IVLEWU7 aMCIRJdS7Xs0r98RKxAwQhnjG9jEK99oOYhV1qWOhHuHQTfR3z4Lor9/NKiSB+W0 tv6ylHarhyKBp3SJDnOxIMWFl3bgCx6ZEdGFer1OPLiDE6loQsSXIr4NVa7J9NqG quxtBDjJaJ5v7HPm7NCsF3MCW7e92uA0zU4LB1GoliKK09KkSrpYjMvelPAdGsbN b6/kYGikZHTJspqoeCMIDH9TRCCD4I/tnlTdv3tarWvIeRihhSdfzE3DHnJQ5vM= =qYjV -----END PGP SIGNATURE----- --=-=-=--