From owner-cvs-src-old@FreeBSD.ORG Tue Mar 3 18:49:55 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25F0710656F2 for ; Tue, 3 Mar 2009 18:49:55 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 128118FC08 for ; Tue, 3 Mar 2009 18:49:55 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n23InsnX002762 for ; Tue, 3 Mar 2009 18:49:54 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n23InsKH002761 for cvs-src-old@freebsd.org; Tue, 3 Mar 2009 18:49:54 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200903031849.n23InsKH002761@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Tue, 3 Mar 2009 18:47:33 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_pppoe.c ng_pppoe.h src/sys/netgraph/atm ng_ccatm.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 18:49:55 -0000 ed 2009-03-03 18:47:33 UTC FreeBSD src repository Modified files: sys/netgraph ng_pppoe.c ng_pppoe.h sys/netgraph/atm ng_ccatm.h Log: SVN rev 189315 on 2009-03-03 18:47:33Z by ed Make Netgraph compile with Clang. Clang disallows structs with variable length arrays to be nested inside other structs, because this is in violation with ISO C99. Even though we can keep bugging the LLVM folks about this issue, we'd better just fix our code to not do this. This code seems to be the only code in the entire source tree that does this. I haven't tested this patch by using the kernel modules in question, but Diane Bruce and I have compared disassembled versions of these kernel modules. We would have expected them to be exactly the same, but due to randomness in the register allocator and reordering of instructions, there were some minor differences. Approved by: julian Revision Changes Path 1.3 +0 -1 src/sys/netgraph/atm/ng_ccatm.h 1.95 +12 -11 src/sys/netgraph/ng_pppoe.c 1.26 +0 -2 src/sys/netgraph/ng_pppoe.h