From owner-cvs-all@FreeBSD.ORG Fri Jan 27 21:41:11 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81D8516A420; Fri, 27 Jan 2006 21:41:11 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16EDF43D5F; Fri, 27 Jan 2006 21:41:06 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 7149208 for multiple; Fri, 27 Jan 2006 16:39:57 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k0RLf3AU053749; Fri, 27 Jan 2006 16:41:04 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Jason Evans Date: Fri, 27 Jan 2006 16:42:03 -0500 User-Agent: KMail/1.9.1 References: <200601270236.k0R2ai2x067283@repoman.freebsd.org> <20060127025150.GA57825@nagual.pp.ru> <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> In-Reply-To: <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601271642.06181.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1254/Fri Jan 27 12:22:39 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andrey Chernov , cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2006 21:41:11 -0000 On Thursday 26 January 2006 22:02, Jason Evans wrote: > On Jan 26, 2006, at 6:51 PM, Andrey Chernov wrote: > > I worry about my system performance. Could you please make all > > statistics > > and debug code conditional, debending on some flags which could be > > set as > > malloc options? Even in case this is a test period now, some people > > perhaps don't want some tests. It is much easy to turn some tests > > off via > > malloc options than to comment out manually corresponding malloc.c > > defines > > after each cvsup. > > Unfortunately, run-time checks for the debugging features are > expensive, since the debugging code is scattered throughout > malloc.c. This pretty much mandates compile-time configuration, for > performance reasons. > > I can disable statistics and debugging, if there's a general > consensus to do so. How much performance difference is the debug/ > stats code making for you? I've only been disabling debug/stats for > benchmarking purposes, so I don't have a good feel for how much it > impacts overall system performance. Perhaps you could add some Makefile foo so Andrey can just add some entries to his /etc/make.conf (like NO_MALLOC_DEBUG, NO_MALLOC_STATS). This would give Andrey what he needs w/o adding runtime overhead and w/o requiring Andrey to hack the source each time. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org