From nobody Sun Nov 3 16:02:24 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhK9s0KJzz5cMXZ; Sun, 03 Nov 2024 16:02:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhK9r4S2hz4MqW; Sun, 3 Nov 2024 16:02:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730649744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3xlONT6R1p9X07a4MtgJvg5S3EO8n0PQSRK2SNbq5o8=; b=sXdzlElEr9v27sRfPf+7Q17xbAnQ+avcx52AKTDyVZ1F6PCzrq845KttSpg7ZuDd6wAnOm C34ATcy+jP5z15QCqnSVxFCr39laHcFiFJ3+gGUkAtQWGC+GhQdrBZ1HUd52JuHrh9Qbeb kaXumRnzIJ+btyEhbynkp2i2OG0WdWA9YiMgiPBpaG0KCcz5vaUvxNNlygu2euuIu6xtDo 8pE2iVk5pncqdhfbH5BygKBH9uTwTWepHdbaZRd6NBUGjicMbzy2q2L3ufxGN1eZKK/yyI 0+iQpjCCJWmItbUCa7IP9t1mv1+6lETfbtiBjx8UwW6chPyH6GdfXUMUGPWHuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730649744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3xlONT6R1p9X07a4MtgJvg5S3EO8n0PQSRK2SNbq5o8=; b=HZ18AFfFgI+NkbLxOhZEef0KsOzVd30pq14yoEVrh65IDIzX2mYY1vnfwjokbRs9MuNX6m XaBBOuO2U2ZMKEn3FBec0h0U0lJxY3mpSLi9bZaMk4S/ILTgkUFNSY+jUcaqHsU/va6rdN X+WUHjVWvmhv9bcljCnzX9w26kCaJ0Wz1Zap1oVWgxNv6dwgf8DXEI+OKd25cCRZ+m++Xy vgnSwZb5DYMGXLx6R+YbuewLa5Ulctdbrai6D8TuulGH2M8AEBI7uy1SBsMbfw/dLOatko LBw24ECd09J7gPFE3hTGsJ4I98T3Pyx477y5yJ3AMrd+Vp0bM9jxnXrvqh7wKw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730649744; a=rsa-sha256; cv=none; b=guBiiuiOYiUWAFbTgag7CWqqJZzaL48iX6hhKm/u3m8KfAOedVwDwYN0BQVMrzxe7wIsXq 3lUOrM/P6+A4fI2LFqOPkYION+8ddFcxeRNLSpd/38osTEg1rGj0ORHl/VMuPp4DgPQWRi 8P8oZBTh+wOD4oojUg0oIC4vo8HPuPymP9VR23Yk8NmfUWzKepTh1Q/tOoUqpAmRIAFbgV swZtOSldWpJ39mG+HiT0PzFq0LTiZKykz2XWEQj7zQjNZQn76mT+hEXnUxg3wdaS4BVWvj EOP12kRDnP93RmhhwfFCEJVTIlpRlU4O+9VcFRNEgJbPHsZclbb42Xf0fEcxqg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhK9r43TBzwQQ; Sun, 3 Nov 2024 16:02:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A3G2Owv015645; Sun, 3 Nov 2024 16:02:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A3G2Onc015642; Sun, 3 Nov 2024 16:02:24 GMT (envelope-from git) Date: Sun, 3 Nov 2024 16:02:24 GMT Message-Id: <202411031602.4A3G2Onc015642@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 5fa51c3653b1 - stable/14 - ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5fa51c3653b14b364e26a4cce2733c7be6ee7721 Auto-Submitted: auto-generated The branch stable/14 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=5fa51c3653b14b364e26a4cce2733c7be6ee7721 commit 5fa51c3653b14b364e26a4cce2733c7be6ee7721 Author: Colin Percival AuthorDate: 2024-10-22 14:47:30 +0000 Commit: Colin Percival CommitDate: 2024-11-03 16:01:27 +0000 ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 AWS Graviton [1234] systems have a bug in their ACPI where they mark the PL061's GPIO pins as needing to be configured in PullUp mode (in fact the PL061 has no pullup/pulldown resistors); this flag needs to be removed in order for _AEI objects to be handled on these systems. Reviewed by: Ali Saidi MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47239 (cherry picked from commit 2f3f867ac6dd7ff3769366b828b79c44b38828e1) --- release/tools/ec2.conf | 5 +++++ sys/dev/acpica/acpivar.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/release/tools/ec2.conf b/release/tools/ec2.conf index 522aaa400520..963c6ff4957b 100644 --- a/release/tools/ec2.conf +++ b/release/tools/ec2.conf @@ -63,6 +63,11 @@ ec2_common() { # nodes, but apply the workaround just in case. echo 'hw.broken_txfifo="1"' >> ${DESTDIR}/boot/loader.conf + # Graviton 1 through Graviton 4 have a bug in their ACPI where they + # mark the PL061's pins as needing to be configured in PullUp mode + # (in fact the PL061 has no pullup/pulldown resistors). + echo 'debug.acpi.quirks="8"' >> ${DESTDIR}/boot/loader.conf + # Load the kernel module for the Amazon "Elastic Network Adapter" echo 'if_ena_load="YES"' >> ${DESTDIR}/boot/loader.conf diff --git a/sys/dev/acpica/acpivar.h b/sys/dev/acpica/acpivar.h index afb0a6909e1a..eb6022cde159 100644 --- a/sys/dev/acpica/acpivar.h +++ b/sys/dev/acpica/acpivar.h @@ -224,12 +224,15 @@ extern struct mtx acpi_mutex; * ACPI_Q_MADT_IRQ0: Specifies that ISA IRQ 0 is wired up to pin 0 of the * first APIC and that the MADT should force that by ignoring the PC-AT * compatible flag and ignoring overrides that redirect IRQ 0 to pin 2. + * ACPI_Q_AEI_NOPULL: Specifies that _AEI objects incorrectly designate pins + * as "PullUp" and they should be treated as "NoPull" instead. */ extern int acpi_quirks; #define ACPI_Q_OK 0 #define ACPI_Q_BROKEN (1 << 0) #define ACPI_Q_TIMER (1 << 1) #define ACPI_Q_MADT_IRQ0 (1 << 2) +#define ACPI_Q_AEI_NOPULL (1 << 3) #if defined(__amd64__) || defined(__i386__) /*