From owner-cvs-src@FreeBSD.ORG  Tue Apr 13 18:18:06 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9EA5516A4CE; Tue, 13 Apr 2004 18:18:06 -0700 (PDT)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E1C0443D46; Tue, 13 Apr 2004 18:18:05 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i3E1I04u007515;	Wed, 14 Apr 2004 11:18:00 +1000
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i3E1Hvsg022826;	Wed, 14 Apr 2004 11:17:58 +1000
Date: Wed, 14 Apr 2004 11:17:57 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Ruslan Ermilov <ru@freebsd.org>
In-Reply-To: <20040413125558.GC46878@ip.net.ua>
Message-ID: <20040414110419.M5769@gamplex.bde.org>
References: <200404092326.i39NQGUC078871@repoman.freebsd.org>
 <xzpoepwujt9.fsf@dwp.des.no> <20040413125558.GC46878@ip.net.ua>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Dag-Erling Sm?rgrav <des@des.no>
cc: src-committers@freebsd.org
cc: Maksim Yevmenkin <emax@freebsd.org>
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/usr.bin/bluetooth/rfcomm_sppd rfcomm_sdp.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 01:18:06 -0000

On Tue, 13 Apr 2004, Ruslan Ermilov wrote:

> On Tue, Apr 13, 2004 at 02:46:42PM +0200, Dag-Erling Sm?rgrav wrote:
> > Maksim Yevmenkin <emax@FreeBSD.org> writes:
> > >   Log:
> > >   Use uint instead of u_int
> >
> > What's wrong with "unsigned int"?

It is excessively verbose (" int" in "unsigned int" is noise), and is
a style bug in many places (e.g., in most parts of the kernel, and in
utilities that are closely related to the kernel and/or use kernel
style, e.g., vmstat).  These places spell "unsigned[ int]" as u_int.

> The actual commit changed a bunch of u_int*_t to uint*_t.
> I'd be confused too if I wasn't asked to review the patches.  ;)

Indeed.  uint is SYSV compatibility cruft, but the commit actually changed
the BSDish u_int prefix to the C99 uint prefix.

I used to enforce not using uint or ushort in the kernel:

%%%
Index: types.h
===================================================================
RCS file: /home/ncvs/src/sys/sys/types.h,v
retrieving revision 1.85
diff -u -2 -r1.85 types.h
--- types.h	7 Apr 2004 04:19:50 -0000	1.85
+++ types.h	14 Apr 2004 01:13:27 -0000
@@ -50,10 +49,12 @@
 typedef	unsigned int	u_int;
 typedef	unsigned long	u_long;
+#ifndef _KERNEL
 typedef	unsigned short	ushort;		/* Sys V compatibility */
 typedef	unsigned int	uint;		/* Sys V compatibility */
 #endif
+#endif

 /*
- * XXX POSIX sized integrals that should appear only in <sys/stdint.h>.
+ * XXX C99 integer types that should appear only in <sys/stdint.h>.
  */
 #ifndef _INT8_T_DECLARED
%%%

This used to work, but hasn't been tested recently.

Bruce