Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Apr 2017 06:05:34 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r317244 - head/sys/netinet
Message-ID:  <201704210605.v3L65Yx1020749@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Fri Apr 21 06:05:34 2017
New Revision: 317244
URL: https://svnweb.freebsd.org/changeset/base/317244

Log:
  Represent "a syncache overflow hasn't happend yet" by using
  -(SYNCOOKIE_LIFETIME + 1) instead of INT64_MIN, since it is
  good enough and works when time_t is int32 or int64.
  This fixes the issue reported by cy@ on i386.
  
  Reported by:	cy
  MFC after:	1 week
  Sponsored by:	Netflix, Inc.

Modified:
  head/sys/netinet/tcp_syncache.c

Modified: head/sys/netinet/tcp_syncache.c
==============================================================================
--- head/sys/netinet/tcp_syncache.c	Fri Apr 21 02:11:44 2017	(r317243)
+++ head/sys/netinet/tcp_syncache.c	Fri Apr 21 06:05:34 2017	(r317244)
@@ -260,7 +260,8 @@ syncache_init(void)
 			 &V_tcp_syncache.hashbase[i].sch_mtx, 0);
 		V_tcp_syncache.hashbase[i].sch_length = 0;
 		V_tcp_syncache.hashbase[i].sch_sc = &V_tcp_syncache;
-		V_tcp_syncache.hashbase[i].sch_last_overflow = INT64_MIN;
+		V_tcp_syncache.hashbase[i].sch_last_overflow =
+		    -(SYNCOOKIE_LIFETIME + 1);
 	}
 
 	/* Create the syncache entry zone. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704210605.v3L65Yx1020749>