From owner-freebsd-alpha Fri Dec 8 14:24:28 2000 From owner-freebsd-alpha@FreeBSD.ORG Fri Dec 8 14:24:26 2000 Return-Path: Delivered-To: freebsd-alpha@freebsd.org Received: from post.mail.nl.demon.net (post-10.mail.nl.demon.net [194.159.73.20]) by hub.freebsd.org (Postfix) with ESMTP id 435D937B400; Fri, 8 Dec 2000 14:24:25 -0800 (PST) Received: from [212.238.54.101] (helo=freebie.demon.nl) by post.mail.nl.demon.net with smtp (Exim 3.14 #2) id 144VwF-00012k-00; Fri, 08 Dec 2000 22:24:23 +0000 Received: (from wkb@localhost) by freebie.demon.nl (8.11.1/8.11.0) id eB8MO3G01485; Fri, 8 Dec 2000 23:24:03 +0100 (CET) (envelope-from wkb) Date: Fri, 8 Dec 2000 23:24:03 +0100 From: Wilko Bulte To: Bill Paul Cc: John Baldwin , alpha@freebsd.org Subject: Re: cvs commit: src/sys/alpha/conf GENERIC Message-ID: <20001208232403.A1471@freebie.demon.nl> References: <20001208212728.9D8D737B400@hub.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20001208212728.9D8D737B400@hub.freebsd.org>; from wpaul@freebsd.org on Fri, Dec 08, 2000 at 01:27:28PM -0800 X-OS: FreeBSD 4.2-STABLE X-PGP: finger wilko@freebsd.org Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, Dec 08, 2000 at 01:27:28PM -0800, Bill Paul wrote: > Ok. There's something about the way the descriptor memory is being > allocated that I don't like. I can't quite put my finger on what it > is. I usually resort to contigmalloc() when I allocate descriptor > space; it's not always necessary but it helps me sleep at night. Plus > you know you're getting memory that's aligned on the right boundary. > > Wilko: please try me the following patch to if_tx.c. In addition to > tweaking the descriptor allocation, I added some code to force the > proper payload alignment on received packets. I'm not positive, but > I think you need this for this chip too. Looks like I lack a .h somewhere: mx5# make cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mno-fp-regs -Wa,-mev56 ../../pci/if_tx.c ../../pci/if_tx.c: In function `epic_rx_done': ../../pci/if_tx.c:930: `ETHER_ALIGN' undeclared (first use in this function) ../../pci/if_tx.c:930: (Each undeclared identifier is reported only once ../../pci/if_tx.c:930: for each function it appears in.) *** Error code 1 Note that I'm testing on 4.2R at the moment. No -current for me on this alpha at the moment. -- Wilko Bulte Arnhem, the Netherlands wilko@freebsd.org http://www.freebsd.org http://www.nlfug.nl To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message