Date: Mon, 25 Feb 2013 07:28:42 +0000 From: Chris Rees <utisoft@gmail.com> To: araujo@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Po-Chien Lin <pclin@freebsd.org>, Ruslan Makhmatkhanov <cvs-src@yandex.ru>, ports-committers@freebsd.org Subject: Re: svn commit: r312904 - head/net-im/imspector Message-ID: <CADLo839Ya32EZjHPT04AOvo2G0X11zxXSsPXMgMdVtiGjBmqug@mail.gmail.com> In-Reply-To: <CAOfEmZgFL%2BN84BaGR-cX1-2a_qPWDdPSenLRrN1uQtL7E8GoJw@mail.gmail.com> References: <201302250425.r1P4Pc9u020378@svn.freebsd.org> <CAOfEmZh3mqERhFPS8eYfgbCsnNtMq5kPiyYQnTHh5=vKnWRv0A@mail.gmail.com> <512AF924.40504@yandex.ru> <CAOfEmZgFL%2BN84BaGR-cX1-2a_qPWDdPSenLRrN1uQtL7E8GoJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Feb 2013 05:51, "Marcelo Araujo" <araujobsdport@gmail.com> wrote: > > > > 2013/2/25 Ruslan Makhmatkhanov <cvs-src@yandex.ru> >> >> Hi, >> >> Marcelo Araujo wrote on 25.02.2013 08:35: >> >>> 2013/2/25 Po-Chien Lin <pclin@freebsd.org> >>> >>>> Author: pclin >>>> Date: Mon Feb 25 04:25:37 2013 >>>> New Revision: 312904 >>>> URL: http://svnweb.freebsd.org/changeset/ports/312904 >>>> >>>> Log: >>>> - Add IPFW suuport [1] and enable it by default [2] >>>> - Trim Makefile header [2] >>>> - Remove invalid entry from MASTER_SITES >>>> - Patch to fix clang compiling >>>> - Tune pkg-plist to pet portlint(1) >>>> >>>> PR: ports/175765 >>>> Submitted by: Oleg_Sch <7zsfx@7zsfx.info> [1] >>>> Approved by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer) [2] >>>> Approved by: swills (mentor) >>>> >>>> >>> Dear Po-Chien, >>> >>> For my eyes, it is pretty much strange when we have two lines of "Approved >>> by" or more then one line of Submitted by or wherever, usually we use only >>> one line, and something like bellow: >>> >>> Approve by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer) >>> swills (mentor) >>> >>> An example to submit: >>> >>> PR: ports/1111 [1], ports/22222 [2], ports/33333 [3] >> >> >> Will this line be expanded up to three gnats followups (with commit message) for three different pr's? >> If I recall correctly it was suggested to use exactly this form to make sure everything is right: >> >> PR: ports/1111 [1] >> PR: ports/22222 [2] >> PR: ports/33333 [3] >> >> And I stick this style because of that reason. Can anybody clarify (once again)? >> > > > Yes, would be great if we have more comments, because in the section 16.3 of committers guid[1] does not mention nothing about it. > > [1] http://www.freebsd.org/doc/en/articles/committers-guide/article.html Po-Chien Lin's method is much easier for scripts to parse. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839Ya32EZjHPT04AOvo2G0X11zxXSsPXMgMdVtiGjBmqug>