From nobody Tue Mar 3 12:22:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQFLr1xgjz6T39K for ; Tue, 03 Mar 2026 12:23:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQFLq6HX9z3cmT for ; Tue, 03 Mar 2026 12:22:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-35994d84c6dso697197a91.2 for ; Tue, 03 Mar 2026 04:22:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772540574; cv=none; d=google.com; s=arc-20240605; b=FkSzGf700TsU7tsI1qKeX3EbOx/S9lC8+VqsO3XkSwo5UkArHkynHCQxAia/wJOMXC exG08f42DIW3uK8XD3RsPNuJwYhDv/Cw/eZKe8+VRIeTIgYbSB1rXTE3M37lImIZDHTi Grwr6V9xgspdLtTbkSyxQ5Viwlq5CTlSNJ35Cu7LfkcYR0N/F6HZwmEDE2HGgmt8IsTV D8Ad9qKM3rRDUsU95exnq9rUmJSIrg+yM+qJKPjW+cnXmegpfAnkE1dNeEtRAcrui+/Y TH4JN+qv2V1sYF6b8yGj2P+AO+zibI9opuZOdQTtfXs1aQqOFJtHtqtjepeeGZwXKU2O g3cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=bdE7lbu1GQ/XGD9KX4lBzwzb8cI5hK67bQEE5T2fKU0=; fh=OqHxYOdMZzus1nvvei5Roiv/ASSf+Io0PGk631m/xVA=; b=GKApzKVn4F9U7txnjr48WIkle6+s/H9znNn/e0nzlVdn5gtYu4j+LUP3pFes0Gh97S lzxnDl7mpkWAXX/5aGbuFz4UzSzEr8cEnA9/PX0eVKRIdf2985BF+Ea0VUTzNEGVo1Ji lrhL7q36xEN75jMrqouGZn2+nM2gHNpuGPxRF+eRIQDryUFARL+GJkeqdV0oZFb08cGw hqAXeXdCl6ukdP/yCGAjp03tynmawm4jBRU/snPlogyJY/K2zsCrtUTbiucaR7Eg1EzI y+Fhkxu8tiHJnLLfFMjp3fJrBOaGc0UKR+JfocrHoL9gbr/sif7qq//MUaEHAhBNo84O t7qw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1772540574; x=1773145374; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bdE7lbu1GQ/XGD9KX4lBzwzb8cI5hK67bQEE5T2fKU0=; b=YfCSwlHDT03/bkpA85zPyom0lvjOPd1B9HcZw2GUzBGAN6cgOE/FtWc/XBTYa+MlNQ LBufP3OAGKx2la8afuimMaD3g+h+2S0GNKww1yku5bzQKfDQGIc/uOPcSAjZ2P+4++pH +ujytGWm9CVvY/NyAAprq1GwDiVxD0XUCM59nNbSJ4HjnkyCoj62rfq61jlkAPUEJ33p 4nocZ12+FYjVJ3jgFHPOla1rNTT/BU/qMqU9PbHmmJnm/l7nYx1pq29aeNM59IZipNgK OIwIknuMEigKIl4MAJWnL4OTAo1WPQryNHp6xm+u6l0hjszJElz3AQK1f6OyEsfpHZYe 61RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772540574; x=1773145374; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bdE7lbu1GQ/XGD9KX4lBzwzb8cI5hK67bQEE5T2fKU0=; b=Prx14u/VKPhVRjLMK/ypMC5xL1a3SFPsb8OHFbIBpPmbfMKUXH3Eq9OzWBxLv59gqi OQnIQKyfRAOYuui8WhPfxAxjWjjHPbOcoZx9le2/Rz+6cHo9Vp4+cMxLPTUsAwep82sH kssvJCWh5kxGc0/ae9UBgJuqSA7E6y902a6Eyg4mtjEyxlC40b+pmrIWsjRHrtQm/F2y nXlYBK2n0QhrC8oAluDLNvV/c8+dSthkYikrHwVv9hguxcS3jwTMgS/HdOtRo7Tgwa3v AZ2EHoD1g9aRPtb9hrGyxxnyzfbz3/OggXsRmSzFaKogDin1cSbMT0YQHQRL9UQONv4E 1SOg== X-Forwarded-Encrypted: i=1; AJvYcCWbAhuNE2sphdEf/HRCTPlwyoGLomaVtJLDIy6t3PArUCpgurgbom/8g82XE4pQO6taMrvmQ77eGZYF9/UFZZU52Txn@freebsd.org X-Gm-Message-State: AOJu0YybgMHmLb7vz347iBqGdrcX2ZpMEf6elfWs/p/FG5CegmLIVQrF l+/b7FdMsCNRdivO+kjvUCgTn14zH6ZFf1ZorKhdFnDXkU6qvneuSm9Ht29DE4S6Smmvo8faNtW lkSepkK2VRKjM863WiIy6+P2Ge5pQfCF8LmF+hFK4jQ== X-Gm-Gg: ATEYQzwsY11cJx9z2y0ace6u/Zo3ykgzw5iG5jIgMzmCXlSt2D0Zt0+eddQba6fz3oX B/w+cRqYlTzfF61avIsNqR0mCAaOn5qSofvXKY1bB+zrlqo3m0ryQLRCT8W0d6Q41+OIdnIjjsh VwDnaPIqaM7/NXLUXRAPU8KiHWbpf5uPGB8uCgZTJU38LMaz4CL0UMgB2UuG2KZRZyQijk58pg9 P/qbfo3tTNa2eODg4HtBRIMS/2Ax03Qoq1IFoKh3E7seQmSRqqWUb9HxOB7VY9Aqya8X2cPc7Nm Lb57cq8= X-Received: by 2002:a17:90b:2e0e:b0:359:8d38:cdee with SMTP id 98e67ed59e1d1-3598d38dcbdmr5672727a91.2.1772540573608; Tue, 03 Mar 2026 04:22:53 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 3 Mar 2026 05:22:42 -0700 X-Gm-Features: AaiRm51-d9MmHTvMClVX0KURzOo75eC0I0uaLzl9aojDlLQ-OuEnr3lWSxZtq60 Message-ID: Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` To: Brooks Davis Cc: Enji Cooper , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000003d7be1064c1dc36c" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQFLq6HX9z3cmT X-Spamd-Bar: ---- --0000000000003d7be1064c1dc36c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 3, 2026 at 5:18=E2=80=AFAM Brooks Davis wr= ote: > On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper wrote: > > > > > The branch main has been updated by ngie: > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80= 528f588eb > > > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > > Author: Enji Cooper > > > AuthorDate: 2026-03-03 05:59:50 +0000 > > > Commit: Enji Cooper > > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > > > Run `make obj` before running `make test-includes` > > > > > > Before this change, `make test-includes` (run as part of > buildworld) > > > would place test files in the current directory, which would > clutter up > > > git clones. Run `make obj` beforehand to ensure that the files ar= e > put > > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on t= he > > > noise significantly when running commands like `git status`. > > > > > > > I've never seen this happen. .OBJDIR is created automatically for me > always > > for the last 5 years... I run buildworld all the time. Can you explain > when > > / how it happens more specifically or back out the change? > > The commit message is unintentionally misleading and incomplete. I hit > the problem a week or so ago when fixing gcc12 builds and lacked the > time to follow up. test-includes is fine as part of buildworld, but > when run directly from src does fill tools/build/test-includes with .c > files if you blow away the objdir (which seems to the the only reliably > way to cause test-includes to retest some more complex cases.) > Ah! That should have been in the commit message as the edge case that provoked this. That's a decent explanation, though there's other bits of buildworld that will also cause problems if you do them in isolatio= n and not part of buildworld. This one, though, is important enough to make an exception for, I think. It's one that's most likely to be used in isolation. Warner --0000000000003d7be1064c1dc36c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 3, = 2026 at 5:18=E2=80=AFAM Brooks Davis <brooks@freebsd.org> wrote:
On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh= wrote:
> On Mon, Mar 2, 2026, 11:00???PM Enji Cooper <ngie@freebsd.org> wrote:
>
> > The branch main has been updated by ngie:
> >
> > URL:
> > https://= cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80528f588eb<= /a>
> >
> > commit 912864912b71951f9a636190b1dba80528f588eb
> > Author:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org> > > AuthorDate: 2026-03-03 05:59:50 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org> > > CommitDate: 2026-03-03 05:59:56 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0Run `make obj` before running `make test-inclu= des`
> >
> >=C2=A0 =C2=A0 =C2=A0Before this change, `make test-includes` (run = as part of buildworld)
> >=C2=A0 =C2=A0 =C2=A0would place test files in the current director= y, which would clutter up
> >=C2=A0 =C2=A0 =C2=A0git clones. Run `make obj` beforehand to ensur= e that the files are put
> >=C2=A0 =C2=A0 =C2=A0in `${.OBJDIR}` instead of `${.CURDIR}`. This = helps cut down on the
> >=C2=A0 =C2=A0 =C2=A0noise significantly when running commands like= `git status`.
> >
>
> I've never seen this happen. .OBJDIR is created automatically for = me always
> for the last 5 years... I run buildworld all the time. Can you explain= when
> /=C2=A0 how it happens more specifically or back out the change?

The commit message is unintentionally misleading and incomplete.=C2=A0 I hi= t
the problem a week or so ago when fixing gcc12 builds and lacked the
time to follow up.=C2=A0 test-includes is fine as part of buildworld, but when run directly from src does fill tools/build/test-includes with .c
files if you blow away the objdir (which seems to the the only reliably
way to cause test-includes to retest some more complex cases.)

Ah! That should have been in the commit message as = the edge case
that provoked this. That's a decent explanation= , though there's other
bits of buildworld that will also caus= e problems if you do them in isolation
and not part of buildworld= . This one, though, is important enough to make
an exception for,= I think. It's one that's most likely to be used in isolation.

Warner=C2=A0
--0000000000003d7be1064c1dc36c--