From owner-cvs-all Mon Jun 26 14:13:48 2000 Delivered-To: cvs-all@freebsd.org Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 96EAF37BD1F; Mon, 26 Jun 2000 14:13:37 -0700 (PDT) (envelope-from green@FreeBSD.org) Date: Mon, 26 Jun 2000 17:13:36 -0400 (EDT) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: David O'Brien Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh canohost.c ssh.h sshd.c In-Reply-To: <20000626005726.B11096@dragon.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 26 Jun 2000, David O'Brien wrote: > On Sun, Jun 25, 2000 at 10:44:23PM -0700, Brian Feldman wrote: > > Revision Changes Path > > 1.2 +41 -11 src/crypto/openssh/canohost.c > > Please have cvs@freebsd.org delete this revision. You really, really > should have checked a ``cvs diff'' before committing. 9 of your changes > were white space. No, they weren't. You compared 1.1 with 1.2, it seems. Check out the RCS file for src/crypto/openssh/canohost.c,v. The latest import of OpenSSH included version 1.1.1.2 of canohost.c, and if you diff -r1.1 -r1.1.1.2 you get the whitespace changes you see. God, I sure love CVS. > The addition of the function should have gone into its own file in > src/secure, and if too hard to find the right place there, then as its > own file in src/crypto/openssh/. PLEASE think about the maintance > headache. It belongs with the rest in src/crypto/openssh. It's referenced from there, from sshd.c and defined in ssh.h, so what makes it not belong there? As for maintenance headache, I am planning on getting this into the OpenBSD OpenSSH very soon, and sshd.c/ssh.h/canohost.c will all have less diffs than before. > -- > -- David (obrien@FreeBSD.org) > -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message