From owner-freebsd-sparc64@FreeBSD.ORG  Tue Dec 28 17:35:31 2010
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DD29E106566B
	for <freebsd-sparc64@freebsd.org>; Tue, 28 Dec 2010 17:35:31 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 7081E8FC19
	for <freebsd-sparc64@freebsd.org>; Tue, 28 Dec 2010 17:35:31 +0000 (UTC)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id
	oBSHZUw9038152; Tue, 28 Dec 2010 18:35:30 +0100 (CET)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.4/8.14.4/Submit) id oBSHZUh8038151;
	Tue, 28 Dec 2010 18:35:30 +0100 (CET) (envelope-from marius)
Date: Tue, 28 Dec 2010 18:35:29 +0100
From: Marius Strobl <marius@alchemy.franken.de>
To: gahr@freebsd.org
Message-ID: <20101228173529.GA38083@alchemy.franken.de>
References: <20101228132703.GC68770@gahrfit.gahr.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101228132703.GC68770@gahrfit.gahr.ch>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-sparc64@freebsd.org
Subject: Re: [patch] rename macro parameter list in cpufunc.h
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>, 
	<mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Dec 2010 17:35:31 -0000

On Tue, Dec 28, 2010 at 02:27:04PM +0100, Pietro Cerutti wrote:
> Dear all,
> 
> sys/sparc64/include/cpufunc.h defines macro having a parameter named
> 'xor'. This is a reserved keyword in C++. For this reason, it is
> impossible to use this header in C++ (e.g., by including
> machine/atomic.h).
> 
> This patch [1] renames these parameters to _xor. Please review and/or
> approve (I need an explicit approval in order to commit to src).
> 
> Thanks!
> 
> Best Regards,
> 
> [1] http://people.freebsd.org/~gahr/cpufunc.h.diff

Hrm, I really don't like the inconsistency only renaming "xor"
introduces, rototilling the whole file also seems excessive though
(also that would get it closer to style(9)). Would wrapping it in
__BEGIN_DECLS or something like that work as an alternate solution?

Marius