From owner-freebsd-net@FreeBSD.ORG  Sun Nov 21 18:11:47 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CB28516A4D7; Sun, 21 Nov 2004 18:11:47 +0000 (GMT)
Received: from mx01.bos.ma.towardex.com (mx01.bos.ma.towardex.com
	[65.124.16.9])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9C81043D5E; Sun, 21 Nov 2004 18:11:47 +0000 (GMT)
	(envelope-from haesu@mx01.bos.ma.towardex.com)
Received: by mx01.bos.ma.towardex.com (TowardEX ESMTP 3.0p11_DAKN, from userid
	1001)	id 4FAD12F946; Sun, 21 Nov 2004 13:11:46 -0500 (EST)
Date: Sun, 21 Nov 2004 13:11:46 -0500
From: James <james@towardex.com>
To: gnn@freebsd.org
Message-ID: <20041121181146.GA76095@scylla.towardex.com>
References: <20041115222310.GA93130@scylla.towardex.com>
	<m2u0rj86tx.wl@minion.local.neville-neil.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m2u0rj86tx.wl@minion.local.neville-neil.com>
User-Agent: Mutt/1.4.1i
cc: freebsd-net@freebsd.org
cc: James <haesu@towardex.com>
Subject: Re: Initial review request for IPv6 Fast Forwarding and IP6STEALTH
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Nov 2004 18:11:47 -0000

On Sun, Nov 21, 2004 at 09:12:10AM -0800, gnn@freebsd.org wrote:
> Hi James,
> 
> 	A few comments for you:

Hi George,

Thanks for your good comments and catch on the line 223! I'll integreate 
the fixes soon for the final draft.

-J

> 
> Issues found:
>     ip6_forward_rt is a global value that is used without locking
>     ASSERTS still include the old name apc_inet6_fastfwd
>     Stats are updated directly but I don't think we lock those yet.
>     Don't define M2MMAX in line, put it outside with a comment.
>     If the mbuf is already freed then how can we safely use m->m_pkthdr.rcvif? at line 223
>     Improve the indenting in the commented case at line 298.  I understand the idea, and it's good, but it's a bit confusing to read.
>     Remove #if code at 553 which is specific to the APC product.
> 
> Later,
> George

-- 
James Jun                                            TowardEX Technologies, Inc.
Technical Lead                      Boston IPv4/IPv6 Web Hosting, Colocation and
james@towardex.com            Network design/consulting & configuration services
cell: 1(978)-394-2867           web: http://www.towardex.com , noc: www.twdx.net