From owner-freebsd-net Tue Apr 30 8:41:49 2002 Delivered-To: freebsd-net@freebsd.org Received: from falcon.prod.itd.earthlink.net (falcon.mail.pas.earthlink.net [207.217.120.74]) by hub.freebsd.org (Postfix) with ESMTP id 0AC9837B400 for ; Tue, 30 Apr 2002 08:41:43 -0700 (PDT) Received: from pool0453.cvx21-bradley.dialup.earthlink.net ([209.179.193.198] helo=mindspring.com) by falcon.prod.itd.earthlink.net with esmtp (Exim 3.33 #2) id 172Zl3-0003Uh-00; Tue, 30 Apr 2002 08:41:38 -0700 Message-ID: <3CCEBB15.D89B94E7@mindspring.com> Date: Tue, 30 Apr 2002 08:41:09 -0700 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: mark tinguely Cc: net@FreeBSD.ORG Subject: Re: ip_flow and ipf_tos References: <200204301507.g3UF7tN32713@web.cs.ndsu.nodak.edu> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org mark tinguely wrote: > > Right now, ip_tos (and ipf_tos) is an 8 bit value, of which only > > the first 6 bits are used in the hash, while the hash value pass > > itself is a 32 bit value (in most cases: it's "unsigned"). I'd > > like to push the value into the same space as the src.s_addr > > feedback, which would have the net effect of making 2 more bits > > of the standard implementation useful. > > I have no complaints to your proposal. The question I had was: > what would happen when the high bits implement Early Congestion > Notification (RFC3168)? Wouldn't we want to mask off these bits > from the hash anyway? Yes. It would be nice if such masking were explicit, so that the code could be read by mere mortals, though. 8-). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message