From owner-svn-src-head@FreeBSD.ORG Sun Nov 21 18:51:41 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C0FB1065695; Sun, 21 Nov 2010 18:51:41 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 442638FC16; Sun, 21 Nov 2010 18:51:40 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 1BB5845B36; Sun, 21 Nov 2010 19:51:38 +0100 (CET) Received: from localhost (chello089073192049.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 7D85745683; Sun, 21 Nov 2010 19:51:32 +0100 (CET) Date: Sun, 21 Nov 2010 19:50:44 +0100 From: Pawel Jakub Dawidek To: "Andrey V. Elsukov" Message-ID: <20101121185044.GA14585@garage.freebsd.pl> References: <201011201603.oAKG3rED017856@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <201011201603.oAKG3rED017856@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215570 - head/sbin/geom/class/part X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 18:51:41 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 20, 2010 at 04:03:53PM +0000, Andrey V. Elsukov wrote: > Author: ae > Date: Sat Nov 20 16:03:53 2010 > New Revision: 215570 > URL: http://svn.freebsd.org/changeset/base/215570 >=20 > Log: > Add to gpart(8) an ability to backup partition table and > restore it from given backup. [...] > + { "backup", 0, gpart_backup, { > + { 'l', "backup_labels", NULL, G_TYPE_BOOL}, > + G_OPT_SENTINEL }, > + "[-l] geom" > + }, My opinion was that it would be more handy to always backup labels, but simply not always restore them. I'd much more prefer an option to restore than to backup. Backup should contains everything and one should be able to filter what to restore at restore time. What do you think? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkzpagMACgkQForvXbEpPzQVMQCgjDPTAHg36VU/XNRQOX+rGqCG hEMAn0RqoaAC97zN49oKg0Ybgzqaep8W =vwsQ -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--