From owner-svn-src-stable-8@FreeBSD.ORG  Sat May 19 19:47:02 2012
Return-Path: <owner-svn-src-stable-8@FreeBSD.ORG>
Delivered-To: svn-src-stable-8@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3E1311065670;
	Sat, 19 May 2012 19:47:02 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D9D68FC0A;
	Sat, 19 May 2012 19:47:00 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA05221;
	Sat, 19 May 2012 22:46:58 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SVpcA-000BxI-K4; Sat, 19 May 2012 22:46:58 +0300
Message-ID: <4FB7F8B1.8070403@FreeBSD.org>
Date: Sat, 19 May 2012 22:46:57 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120503 Thunderbird/12.0.1
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
References: <201205191432.q4JEWle6027225@svn.freebsd.org>
	<4FB7ECFC.2020509@FreeBSD.org>
	<3CC44A84-4FF8-4850-B38B-DF0A3C26EAC1@FreeBSD.org>
In-Reply-To: <3CC44A84-4FF8-4850-B38B-DF0A3C26EAC1@FreeBSD.org>
X-Enigmail-Version: 1.5pre
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org
Subject: Re: svn commit: r235650 - stable/8/usr.sbin/mfiutil
X-BeenThere: svn-src-stable-8@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for only the 8-stable src tree
	<svn-src-stable-8.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8>, 
	<mailto:svn-src-stable-8-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-8>
List-Post: <mailto:svn-src-stable-8@freebsd.org>
List-Help: <mailto:svn-src-stable-8-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8>, 
	<mailto:svn-src-stable-8-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 May 2012 19:47:02 -0000

on 19/05/2012 22:34 Bjoern A. Zeeb said the following:
> 
> On 19. May 2012, at 18:57 , Andriy Gapon wrote:
> 
>> on 19/05/2012 17:32 Bjoern A. Zeeb said the following:
>>> Author: bz
>>> Date: Sat May 19 14:32:47 2012
>>> New Revision: 235650
>>> URL: http://svn.freebsd.org/changeset/base/235650
>>>
>>> Log:
>>>  MFC r233713:
[snip]
>>>  To unbreak the build after:	r235625 (?)
> 
> 
> ..
>>> @@ -211,9 +211,8 @@ clear_config(int ac, char **av)
>>> }
>>> MFI_COMMAND(top, clear, clear_config);
>>>
>>> -#define	MFI_ARRAY_SIZE		288
>>> -#define	MAX_DRIVES_PER_ARRAY						\
>>> -	((MFI_ARRAY_SIZE - sizeof(struct mfi_array)) / 8)
>>> +#define MAX_DRIVES_PER_ARRAY MFI_MAX_ROW_SIZE
>>> +#define MFI_ARRAY_SIZE sizeof(struct mfi_array)
>>
>> A small nit: previously MFI_ARRAY_SIZE wasn't used for anything except
>> MAX_DRIVES_PER_ARRAY, now it's not used for anything.
> 
> Whatever else needs to be fixed in HEAD or MFCed to stable I don't know;
> see the last line of my commit message and talk to the other suspects like
> jhb, sbruno, ambrisko, emaste....
> 

I actually missed the first line, that is the fact that it was an MFC.
Somehow I mistook it for a direct commit to fix the build.

-- 
Andriy Gapon