Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 May 2017 20:18:11 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 219642] science/vmd: Suggested changes: typo, dependencies, shebang, license
Message-ID:  <bug-219642-13@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219642

            Bug ID: 219642
           Summary: science/vmd: Suggested changes: typo, dependencies,
                    shebang, license
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: dbn@FreeBSD.org
          Reporter: yuri@rawbw.com
             Flags: maintainer-feedback?(dbn@FreeBSD.org)
          Assignee: dbn@FreeBSD.org

1. There is a typo:
> -LICENSE_NAME_VMD=3D	Visaul Molecular Dynamics Software License Agreement
> +LICENSE_NAME_VMD=3D	Visual Molecular Dynamics Software License Agreement

2. Dependencies are missing:
  Arch package mentions these 2 dependencies
(https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=3Dvmd):
  * 'openbabel: additional file formats support'
  * 'sqlite: dmsplugin'
  They should be made direct dependencies of vmd.

3. USES=3Dshebangfix is missing:
> Error: '/usr/bin/tclsh' is an invalid shebang you need USES=3Dshebangfix =
for 'lib/vmd/plugins/noarch/tcl/topotools1.7/topoatoms.tcl'
> Error: '/usr/bin/tclsh' is an invalid shebang you need USES=3Dshebangfix =
for 'lib/vmd/plugins/noarch/tcl/topotools1.7/topoangles.tcl'
> Error: '/usr/bin/tclsh' is an invalid shebang you need USES=3Dshebangfix =
for 'lib/vmd/plugins/noarch/tcl/topotools1.7/topodihedrals.tcl'
> Error: '/usr/bin/tclsh' is an invalid shebang you need USES=3Dshebangfix =
for 'lib/vmd/plugins/noarch/tcl/topotools1.7/topolammps.tcl'
> Error: '/usr/bin/tclsh' is an invalid shebang you need USES=3Dshebangfix =
for 'lib/vmd/plugins/noarch/tcl/topotools1.7/topoutils.tcl'
> Error: '/usr/bin/tclsh' is an invalid shebang you need USES=3Dshebangfix =
for 'lib/vmd/plugins/noarch/tcl/topotools1.7/topohelpers.tcl'

4. LICENSE doesn't mention that direct source download and package caching =
is
not allowed. There is in fact the direct download link. I suggest to apply
these patches that will allow the packages to be built automatically:

> -MASTER_SITES=3D	http://jedi.ks.uiuc.edu/~johns/raytracer/files/0.99b6/:t=
achyon \
> +MASTER_SITES=3D	http://www.ks.uiuc.edu/Research/vmd/vmd-1.9.3/files/fina=
l/ \
> +		http://jedi.ks.uiuc.edu/~johns/raytracer/files/0.99b6/:tachyon \

> -LICENSE_PERMS_VMD=3D	auto-accept
> +LICENSE_PERMS_VMD=3D	dist-mirror pkg-mirror auto-accept

Thanks,
Yuri

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-219642-13>