From owner-freebsd-hackers Wed Jun 19 10:21:53 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id A44D437B435; Wed, 19 Jun 2002 10:21:07 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 4A8FCAE2AB; Wed, 19 Jun 2002 10:21:07 -0700 (PDT) Date: Wed, 19 Jun 2002 10:21:07 -0700 From: Alfred Perlstein To: Don Lewis Cc: jhb@freebsd.org, hackers@freebsd.org Subject: Re: Suggested fixes for uidinfo "would sleep" messages Message-ID: <20020619172107.GF85935@elvis.mu.org> References: <20020619061332.GA85935@elvis.mu.org> <200206190810.g5J8AKM1065115@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200206190810.g5J8AKM1065115@gw.catspoiler.org> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG re execve() issues... * Don Lewis [020619 01:10] wrote: > On 18 Jun, Alfred Perlstein wrote: > > Thanks a ton for taking care of it, your patch is actually cleaner > > than what I had started on, I'll be committing it shortly. > > While you're working in this area, take a look at execve(). If the > fdcheckstd() test fails, we leak ucred and uidinfo structures, and also > leave the proc locked. The fix is pretty straightforward. I'm a bit confused actually, it looks like just unlocking the proc and then moving the 'exec_fail_dealloc' label higher would fix it, except I'm not sure about the: /* * Handle deferred decrement of ref counts. */ if (textvp != NULL) vrele(textvp); #ifdef KTRACE if (tracevp != NULL) vrele(tracevp); #endif pargs_drop(oldargs); part... should that be before or after exec_fail_dealloc? Any ideas? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message