From owner-svn-ports-all@FreeBSD.ORG Wed Oct 30 17:04:43 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C8560F1; Wed, 30 Oct 2013 17:04:43 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from smtp-out-01.shaw.ca (smtp-out-01.shaw.ca [64.59.136.137]) by mx1.freebsd.org (Postfix) with ESMTP id 72007224E; Wed, 30 Oct 2013 17:04:43 +0000 (UTC) X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=BkBxTXsSVzyY7C2joSQK+JNK4mJr1It1Skr7Xe8+Jh8= c=1 sm=1 a=uwAAQzxx8EsA:10 a=QrugwKR0C_UA:10 a=wAGQQ9Az6v0A:10 a=BLceEmwcHowA:10 a=ICAaq7hcmGcA:10 a=kj9zAlcOel0A:10 a=IbtKDeXwb2+SRU442/pi3A==:17 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=JuK5Ei9pi2tflH0JDXMA:9 a=CjuIK1q_8ugA:10 a=SV7veod9ZcQA:10 a=V7tsTZBp22UA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO spqr.komquats.com) ([96.50.7.119]) by smtp-out-01.shaw.ca with ESMTP; 30 Oct 2013 11:04:36 -0600 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 7C6CAE7; Wed, 30 Oct 2013 10:04:35 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.14.7/8.14.7) with ESMTP id r9UH4ZQk005266; Wed, 30 Oct 2013 10:04:35 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201310301704.r9UH4ZQk005266@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.5 From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Alexey Dokuchaev Subject: Re: svn commit: r332109 - in head/net/vnc: . files In-Reply-To: Message from Alexey Dokuchaev of "Wed, 30 Oct 2013 14:35:59 -0000." <20131030143559.GA34668@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 30 Oct 2013 10:04:35 -0700 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Cy Schubert X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Cy Schubert List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 17:04:43 -0000 In message <20131030143559.GA34668@FreeBSD.org>, Alexey Dokuchaev writes: > On Wed, Oct 30, 2013 at 01:52:16PM +0000, Cy Schubert wrote: > > New Revision: 332109 > > URL: http://svnweb.freebsd.org/changeset/ports/332109 > > > > Log: > > Fix under 10-STABLE and 11-CURRENT. > > > > +.if ${OSVERSION} > 1000000 > > OSVERSION seems inaccurate, should probably be 1000054. > > > +USE_GCC= 4.6+ > > Gerald will bite you for this. :) > > > +.if ${OSVERSION} > 1000000 > > Ditto. > > > + cd ${WRKSRC}/xc && ${MAKE_ENV} make CC=${CC} CXX=${CXX} ${MAKE_ARGS} Wo > rld > > +.else > > cd ${WRKSRC}/xc && make CC=${CC} CXX=${CXX} World > > .endif > > +.endif > > Ideally, the code should be fixed in a way that it would be built again with > any compiler, and all hacks from Makefile removed. The C and C++ code builds with clang. Imake on the other hand has a problem with clang's cpp. The problem is that the clang cpp re-evaluates expressions whereas the GNU cpp does not. Can this be fixed? Possibly with a lot of work but a better solution would be to have cpp behave as it did before. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.