From owner-cvs-all Mon Nov 1 12:32:18 1999 Delivered-To: cvs-all@freebsd.org Received: from apollo.sitaranetworks.com (apollo.sitaranetworks.com [199.103.141.105]) by hub.freebsd.org (Postfix) with ESMTP id 1C3781530A; Mon, 1 Nov 1999 12:30:57 -0800 (PST) (envelope-from grog@lemis.com) Message-ID: <19991029131559.13829@mojave.worldwide.lemis.com> Date: Fri, 29 Oct 1999 13:15:59 -0400 From: Greg Lehey To: Poul-Henning Kamp Cc: Sheldon Hearn , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/vipw vipw.c References: <19991025100200.60989@mojave.worldwide.lemis.com> <4562.941215109@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4562.941215109@critter.freebsd.dk>; from Poul-Henning Kamp on Fri, Oct 29, 1999 at 06:38:29PM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Friday, 29 October 1999 at 18:38:29 +0200, Poul-Henning Kamp wrote: > In message <19991025100200.60989@mojave.worldwide.lemis.com>, Greg Lehey writes: >> On Monday, 25 October 1999 at 2:46:59 -0700, Sheldon Hearn wrote: >>> sheldonh 1999/10/25 02:46:59 PDT >>> >>> Modified files: >>> usr.sbin/vipw vipw.c >>> Log: >>> Do not rely on malloc() to zero-fill allocated memory, since it is >>> not documented as doing so. This fixes a potential segmentation >>> violation. >> >> For performance reasons, I'd strongly hope that malloc() doesn't clear >> memory. > > RTFM ? I suppose so. But I thought it so obvious a bad point for normal use that I was looking more at the theory than the practice. BTW, why a file when you could have an environment variable or a sysctl? Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message