From owner-svn-ports-all@freebsd.org  Sat Mar  4 17:50:36 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89ED7CF9958;
 Sat,  4 Mar 2017 17:50:36 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6C36215B9;
 Sat,  4 Mar 2017 17:50:35 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from anthias (vie-188-118-249-200.dsl.sil.at [188.118.249.200])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id 89E3E3F531;
 Sat,  4 Mar 2017 12:50:25 -0500 (EST)
Date: Sat, 4 Mar 2017 18:50:22 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: ports-committers@freebsd.org, Olivier Duchateau <olivierd@FreeBSD.org>
cc: svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r435415 - head/Mk/Uses
In-Reply-To: <201703041553.v24FrGZM044896@repo.freebsd.org>
Message-ID: <alpine.LSU.2.20.1703041840390.2487@anthias.pfeifer.com>
References: <201703041553.v24FrGZM044896@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Mar 2017 17:50:36 -0000

On Sat, 4 Mar 2017, Olivier Duchateau wrote:
> Log:
>   Fix typos

> Modified: head/Mk/Uses/lxqt.mk
> ==============================================================================
> .for comp in ${_USE_LXQT_ALL}
> . for subcomp in ${${comp}_USE_LXQT_REQ}
> -${comp}_USE_LXQT_REQ+= ${${comp}_USE_LXQR_REQ}
> +${comp}_USE_LXQT_REQ+= ${${subcomp}_USE_LXQT_REQ}
> . endfor
> .endfor

Picking this as just one example, definitely do not want to pick
this commit in particular or you, Olivier!


Let's get better at documenting infrastructure commits (especially).

Sometimes it is important/useful to log at the log, and "fix typo"
(which I've seen a fair bit lately) is not helpful at that. Unless
it's a comment, but even then "Fix typos in comments" or "Fix typos
in description of..." is more useful.

And even when looking at the commit, a bit more guidance what to
look for is helpful.

Gerald (who is guilty of not-too-descriptive commit messages when
	it comes to the gcc*-devel ports following snapshots, but 
	tries hard in other cases)