Date: Fri, 24 Jul 2020 06:59:02 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Renato Botelho <garga@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r542955 - head/archivers/arj Message-ID: <20200724065902.GA76895@FreeBSD.org> In-Reply-To: <202007231923.06NJNwNF002722@repo.freebsd.org> References: <202007231923.06NJNwNF002722@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 23, 2020 at 07:23:58PM +0000, Renato Botelho wrote: > New Revision: 542955 > URL: https://svnweb.freebsd.org/changeset/ports/542955 > > Log: > Pet portlint: Declare USES early This is most definitely a false-positive (as of recently, portlint(1) mishandles USES) and pessimizes readability by breaking natural flow of things. At the very best, you could've moved the USES line above GNU_CONFIGURE, but placing it between closely related IGNORE_PATCHES and EXTRA_PATCHES certainly looks bogus. Please do not blindly trust linters and always check the result from the human perspective. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200724065902.GA76895>