From nobody Thu Feb 17 00:22:06 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1195419C8309; Thu, 17 Feb 2022 00:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jzb9q00FLz4ZRP; Thu, 17 Feb 2022 00:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645057327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yDQ1qYipWSfKApSzxUZ/nsGsMiu9oS89DCt3uiZVC78=; b=d4CDxBRaq0Pwniwv/eRQKwopnucBrcE6u6JgwHFSmaexRKzf3SEyoBb3KdeRtgctMPUire UVj6oAb4gqCCU8H/6nk93Hezn1TIERL6HvlTacaTf38ayu95kZ91HWgdipxOFqA6Ijfk5b zHp4jvBogfB8q01dxiX150ZrV0uw5fAIaooJp2m//ee3qAxwjkHENZ49ODYFz4P2EZHvYi Vt4wFCknckNHgbMU3+I8TdEkriJYJ++uGqoJxd+LpaAOS8N/uDc+dhHHhN82aAwdRlC8BN FgOAz0Fl9rFNqrhQjAIe+gspUPsL30dkDYaV7H3hyKxAuzzlMDom9R/MqfuMuw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D3A281F4F9; Thu, 17 Feb 2022 00:22:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21H0M62j073089; Thu, 17 Feb 2022 00:22:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21H0M6il073088; Thu, 17 Feb 2022 00:22:06 GMT (envelope-from git) Date: Thu, 17 Feb 2022 00:22:06 GMT Message-Id: <202202170022.21H0M6il073088@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: cc4e78d51351 - main - LinuxKPI: 802.11 advertise full offload scanning based on hw_scan only List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cc4e78d51351d6362b0536e326280c1e230648d5 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645057327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yDQ1qYipWSfKApSzxUZ/nsGsMiu9oS89DCt3uiZVC78=; b=iV2CxyA6i7hcpR+2362dLMM5a7T/rUGZ5tYWcN8yQc9RvtkTUtf8rW5CKV5IXyKts4iWCQ lGvEfKwryHqGmYIYEyjpif0/Yi20wvSZzir5uhqDbfGHKOtfY0Iz9/QWhlBNkcGUvny90h /Rh/vs8UfBq8FCiuFeO4IAIjmJfhzmErpz5EgZz/+zBUaK6IFCH+H/SvUD2eI2ISD6EEXC pDv0OJ26EUxsm+nEU5OfiRjH58ZApUQcitAbaRfQw5WnSfePrC0otzKifjQ5fV//PBBRdA EQ1WF+ywxVYz2wXMbm1BxJPjnx22t3KKHgBqVbeTIG7a3TD/y+oUjtoa+N4wxA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645057327; a=rsa-sha256; cv=none; b=whAMJ15NQ7FgdhqkiqdjpDbF0Qo8YFnP9eARJ5F78qvQAyy9Fop8LBA7ivZariAspqnGnY C/Xg2C7Bi0bqwOLqSCmhMNLxlO9VwmKcv5J+m3jWVtfAb/c3qFJi1Fq/xIrlfNECtt83Tv 8qifOVMe2nBgSqu2CWzBrlmPFhu9DkWFXdzPK4Ed9qyi3Eln8WV+If6kuS4D3V6QarqEwV VW6yzxn1/JLvoadeqEBQ4KZD5SMcO72GSLGxdiX8rNUDahYOnPd9NfFFZEopSjUe7oMewM 0h2QRdmBunFQYdDtubz2Q0DB8CAI2UBXleopR2QUHqvPpgImuOEU/Kbxaok7tg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=cc4e78d51351d6362b0536e326280c1e230648d5 commit cc4e78d51351d6362b0536e326280c1e230648d5 Author: Bjoern A. Zeeb AuthorDate: 2022-02-17 00:15:56 +0000 Commit: Bjoern A. Zeeb CommitDate: 2022-02-17 00:15:56 +0000 LinuxKPI: 802.11 advertise full offload scanning based on hw_scan only We disabled hw_scan for drivers not advertising SINGLE_SCAN_ON_ALL_BANDS. Do not depend on this hw flag to set IEEE80211_FEXT_SCAN_OFFLOAD for net80211 as otherwise scanning will never work. Long-term we probably want to re-think how we do/integrate hw_scan better in net80211. Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/compat/linuxkpi/common/src/linux_80211.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 5aaae47a3e41..b5fde7e10781 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2879,9 +2879,14 @@ linuxkpi_ieee80211_ifattach(struct ieee80211_hw *hw) /* Scanning is a different kind of beast to re-work. */ ic->ic_caps |= IEEE80211_C_BGSCAN; #endif - if (lhw->ops->hw_scan && - ieee80211_hw_check(hw, SINGLE_SCAN_ON_ALL_BANDS)) { - /* Advertise full-offload scanning */ + if (lhw->ops->hw_scan) { + /* + * Advertise full-offload scanning. + * + * Not limiting to SINGLE_SCAN_ON_ALL_BANDS here as otherwise + * we essentially disable hw_scan for all drivers not setting + * the flag. + */ ic->ic_flags_ext |= IEEE80211_FEXT_SCAN_OFFLOAD; }