From owner-svn-src-all@freebsd.org Tue Jul 28 07:23:17 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3D319AB57F; Tue, 28 Jul 2015 07:23:17 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A21487C7; Tue, 28 Jul 2015 07:23:17 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by oige126 with SMTP id e126so64715890oig.0; Tue, 28 Jul 2015 00:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=gBAaqRMGH9jPkj1qaMNJZvjMAVkzPJpPy1jBRBEOBc4=; b=zTdUXgYYvBdyx4utIn2eweSgCULKFp8R6ZObHy+LLyFMDkc4LX+Lxetk1MP+iZR+LS iRSTRssgOCzTkj+ZhrDSPtDiarducLBNkWOivgMjcZU7rjMR1JNsfKHENYx4/zhqR/Z2 I/Vj+vnKhamutWPFC0HE0xBrIVjKCpbZGpJblQPvxQI3QKbPrNaIfq0Y9IsTTLU+ASmh NNO8MSiaq/5SPiIz4N/KrLr4RXQIJrG2mV3s7szI3KKEua3u3x5gF4soCgj0tBpQeY8B aLzHmJI7T1iTqJuw5Z2pEVuLcCBtIJH2vDkypXZVil15QPF47lDk4Htd9qndNSj1/ci+ W7zQ== MIME-Version: 1.0 X-Received: by 10.202.200.151 with SMTP id y145mr30768414oif.111.1438068196916; Tue, 28 Jul 2015 00:23:16 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Tue, 28 Jul 2015 00:23:16 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <201507280232.t6S2WfSq043383@repo.freebsd.org> Date: Tue, 28 Jul 2015 15:23:16 +0800 Message-ID: Subject: Re: svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush usr.sbin/ypserv From: Marcelo Araujo To: Ed Schouten Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2015 07:23:18 -0000 2015-07-28 15:05 GMT+08:00 Ed Schouten : > Hi Marcelo, > > Thanks for working on this! > > 2015-07-28 4:32 GMT+02:00 Marcelo Araujo : > > -struct ypalias { > > +const struct ypalias { > > char *alias, *name; > > -} ypaliases[] = { > > +} static ypaliases[] = { > > { "passwd", "passwd.byname" }, > > { "master.passwd", "master.passwd.byname" }, > > { "shadow", "shadow.byname" }, > > I seem to remember that certain compilers (Intel?) are pretty picky > about the ordering of 'static' and 'const'. > > const static int i; // Compiler error. > > It's also inconsistent with the rest of our codebase, where we > typically put 'static' in front of the type. Could you please change > this to the following? > > static const struct ypalias { > ... > } ypaliases[] = { > ... > }; > > Thanks! > Hello Ed, Thanks to point it out. I got a problem with sparc64, exactly because of that. I will fix it later. All the best. -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)