From owner-freebsd-net@FreeBSD.ORG Tue Mar 31 05:53:04 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 01AB03B1; Tue, 31 Mar 2015 05:53:03 +0000 (UTC) Received: from mail-ig0-x22f.google.com (mail-ig0-x22f.google.com [IPv6:2607:f8b0:4001:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5B85989; Tue, 31 Mar 2015 05:53:03 +0000 (UTC) Received: by igcxg11 with SMTP id xg11so8669849igc.0; Mon, 30 Mar 2015 22:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=lVTsiyKOfbNqhswY6RepkW332BXZAS/2vTRWPfdi2U8=; b=hZvPl1NsZK2GJ/PzpAir88l1zLzNno/QxIAOwzjN/4/oeTmEZ3Z4X91NZDSQYlFSMe lW5X4qTDtct32THm7rB25xnxVhbIUao68Gt/Rl4FyexDuKDVKobkn9I3xSbCgqT6cNCU J4VrlVJ+h1wI/d+uWbqBRuWmZw8B5KabFumDWNbN7s34SOWFachTKA3viZuQraiLb4dA IjwlBlkrCs48oSN7hb/cn4HGyhQv1lCPwcfd3jqzg7PXcnFmqZ9GIoOnuQTEtowvGJWf fbikpWM29N6vIYRm/bXJKPqApYAu4iSoYu6yAz2u3Op0twfe7KASakPtOpi2SaaUwqTA Dvaw== MIME-Version: 1.0 X-Received: by 10.50.67.100 with SMTP id m4mr1787394igt.32.1427781183183; Mon, 30 Mar 2015 22:53:03 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Mon, 30 Mar 2015 22:53:03 -0700 (PDT) In-Reply-To: <20150331050628.GJ10892@strugglingcoder.info> References: <20150323233908.GT53237@strugglingcoder.info> <20150323234214.GU53237@strugglingcoder.info> <20150324154931.GC53237@strugglingcoder.info> <20150330225945.GI10892@strugglingcoder.info> <20150331050628.GJ10892@strugglingcoder.info> Date: Mon, 30 Mar 2015 22:53:03 -0700 X-Google-Sender-Auth: K3z4aJyurtwrC5QMqp1lePpC6CA Message-ID: Subject: Re: Full 32bit flowid from igb(4) From: Adrian Chadd To: hiren panchasara Content-Type: text/plain; charset=UTF-8 Cc: Jack F Vogel , FreeBSD Net , erj@freebsd.org, Jack Vogel , Jason Wolfe X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 05:53:04 -0000 No, you're absolutely right. However, you (a) get flowid for L3/L4 V4/v6 but not other things, and (b) I was worried about changing the default behaviour of the driver, and who knows what other weird crap people may have done to their local driver. stuff like enabled checksums instead, or hacked in flowtable support. :) So, I'm totally fine if you want to populate the flowid for a given flow. Totally okay. You just can't set it blindly - you can only set it when the relevant descriptor bits say "it's a flowid!". Then I guess we'll figure out if something breaks down the line. -adrian