Date: Mon, 30 Mar 2015 22:53:03 -0700 From: Adrian Chadd <adrian@freebsd.org> To: hiren panchasara <hiren@strugglingcoder.info> Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, erj@freebsd.org, Jack Vogel <jfvogel@gmail.com>, Jason Wolfe <nitroboost@gmail.com> Subject: Re: Full 32bit flowid from igb(4) Message-ID: <CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A@mail.gmail.com> In-Reply-To: <20150331050628.GJ10892@strugglingcoder.info> References: <20150323233908.GT53237@strugglingcoder.info> <20150323234214.GU53237@strugglingcoder.info> <CAFOYbc=f3OT85z50uqYEnBUkEej=8FRnRP8TpQuTStgqUEoDTA@mail.gmail.com> <20150324154931.GC53237@strugglingcoder.info> <CAJ-Vmo=ajfWokQ3bdu1Ww8kV3AdVwwsDpoS9y_%2Bywk%2BgcrbBvQ@mail.gmail.com> <20150330225945.GI10892@strugglingcoder.info> <CAJ-Vmom1tE6g=ta-DPLDF%2Bnp0GOpFYOXn=PkspaALfazz-n4Gg@mail.gmail.com> <20150331050628.GJ10892@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
No, you're absolutely right. However, you (a) get flowid for L3/L4 V4/v6 but not other things, and (b) I was worried about changing the default behaviour of the driver, and who knows what other weird crap people may have done to their local driver. stuff like enabled checksums instead, or hacked in flowtable support. :) So, I'm totally fine if you want to populate the flowid for a given flow. Totally okay. You just can't set it blindly - you can only set it when the relevant descriptor bits say "it's a flowid!". Then I guess we'll figure out if something breaks down the line. -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A>