From owner-svn-src-projects@FreeBSD.ORG Tue Sep 16 16:30:31 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1A0C7AC5; Tue, 16 Sep 2014 16:30:31 +0000 (UTC) Received: from mail-qa0-x232.google.com (mail-qa0-x232.google.com [IPv6:2607:f8b0:400d:c00::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E47E80F; Tue, 16 Sep 2014 16:30:30 +0000 (UTC) Received: by mail-qa0-f50.google.com with SMTP id dc16so124316qab.23 for ; Tue, 16 Sep 2014 09:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mF9sK2y8uKNd01vejSxxesOSGm27Z3zuFw6HGatt0QQ=; b=yMrJyEp469S/r/viLj2N+LjFt2UTvynfEgxQ1MfpbVuzHs8rfrDldeDwiVmBURioY1 drnetTFQ6VL6RMCDxIS99Tpha9wctidGTVxKPIC9zjbHazcN8eypnBl0kbKQNr4qyBY4 h4NRa0P09n90Kx7E9067UDJRWJnh02asL7zMoAi58785Q7CiVk9nZoFEy6NsC1UiRAJv phx5iY8/pncKVlUESTrAli22hQIk+Huev6A/ZfNMKmYFh9UMcejuAgUngt7pydBVn5gc 59C/iFh1bcZ2hASw/yr6CZfAw2n2Z8EgaX8sPLJfLpHFLJP5QVIKtEicMTgYv0vF5yu1 fAXQ== MIME-Version: 1.0 X-Received: by 10.224.8.131 with SMTP id h3mr46647794qah.35.1410885026645; Tue, 16 Sep 2014 09:30:26 -0700 (PDT) Received: by 10.140.84.80 with HTTP; Tue, 16 Sep 2014 09:30:26 -0700 (PDT) In-Reply-To: <54182FB5.6000503@FreeBSD.org> References: <201409160401.s8G41ue5005441@svn.freebsd.org> <54182FB5.6000503@FreeBSD.org> Date: Tue, 16 Sep 2014 09:30:26 -0700 Message-ID: Subject: Re: svn commit: r271662 - projects/bhyve_svm/sys/amd64/vmm/amd From: Neel Natu To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: svn-src-projects@freebsd.org, "src-committers@freebsd.org" , Neel Natu X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Sep 2014 16:30:31 -0000 Hi Andriy, On Tue, Sep 16, 2014 at 5:40 AM, Andriy Gapon wrote: > > [picking a random commit] > > Neel, > > are there any strong reasons not to merge this branch to head? > Almost there :-) Just tying up loose ends and planning to merge it back to head in a week (or two at the most). best Neel > > On 16/09/2014 07:01, Neel Natu wrote: >> Author: neel >> Date: Tue Sep 16 04:01:55 2014 >> New Revision: 271662 >> URL: http://svnweb.freebsd.org/changeset/base/271662 >> >> Log: >> Minor cleanup. >> >> Get rid of unused 'svm_feature' from the softc. >> >> Get rid of the redundant 'vcpu_cnt' checks in svm.c. There is a similar check >> in vmm.c against 'vm->active_cpus' before the AMD-specific code is called. >> >> Submitted by: Anish Gupta (akgupt3@gmail.com) >> >> Modified: >> projects/bhyve_svm/sys/amd64/vmm/amd/svm.c >> projects/bhyve_svm/sys/amd64/vmm/amd/svm_softc.h > > > -- > Andriy Gapon