From owner-svn-src-head@FreeBSD.ORG Tue Sep 10 06:01:33 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 60C0A4D6; Tue, 10 Sep 2013 06:01:33 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 49F522C67; Tue, 10 Sep 2013 06:01:33 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8A61XT4052678; Tue, 10 Sep 2013 06:01:33 GMT (envelope-from obrien@freefall.freebsd.org) Received: (from obrien@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8A61XBV052586; Tue, 10 Sep 2013 06:01:33 GMT (envelope-from obrien) Date: Mon, 9 Sep 2013 23:01:32 -0700 From: "David O'Brien" To: John-Mark Gurney , re@freebsd.org Subject: Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni Message-ID: <20130910060132.GA61541@dragon.NUXI.org> References: <201309031831.r83IVNkh026523@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201309031831.r83IVNkh026523@svn.freebsd.org> X-Operating-System: FreeBSD 10.0-CURRENT X-MUA-Host: dragon.NUXI.org X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-NSA-real-insignia: https://www.eff.org/sites/default/files/nsa-all-your-data.png User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: obrien@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2013 06:01:33 -0000 On Tue, Sep 03, 2013 at 06:31:23PM +0000, John-Mark Gurney wrote: > Log: > Use the fact that the AES-NI instructions can be pipelined to improve > performance... Use SSE2 instructions for calculating the XTS tweek > factor... Let the compiler do more work and handle register allocation > by using intrinsics, now only the key schedule is in assembly... Hi John-Mark, Unfortunately this does not work with /usr/bin/gcc (which I still use as /usr/bin/cc on this old IBM T60 laptop due to clang's enormous pestimation on 'make world' and build times. Please fix this ASAP or back it out out of 10-CURRENT as it does not work with /usr/bin/gcc: 1. /usr/bin/gcc cannot handle the "-maes" option. I committed r255440 to address this. 2. /usr/src/sys/modules/aesni/../../crypto/aesni/aesencdec.h:30:23: error: wmmintrin.h: No such file or directory and then a cascade of errors follow. For now, I've sent a patch to re@ for approval to remove the 'aesni' module from the build if not using clang. But the LINT build is still broken with /usr/bin/gcc. > Replace .byte hard coded instructions w/ the proper instructions now > that both clang and gcc support them... Is this out-of-tree latest GCC that supports this? thanks, -- -- David (obrien@FreeBSD.org)