From owner-freebsd-current@FreeBSD.ORG  Wed Aug  4 18:27:52 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3DD611065673
	for <freebsd-current@freebsd.org>; Wed,  4 Aug 2010 18:27:52 +0000 (UTC)
	(envelope-from Hans-Joerg_Hoexer@genua.de)
Received: from gg.genua.de (unknown [IPv6:2001:a60:f08e:c000::1])
	by mx1.freebsd.org (Postfix) with ESMTP id D8FAD8FC08
	for <freebsd-current@freebsd.org>; Wed,  4 Aug 2010 18:27:51 +0000 (UTC)
Received: from gg.genua.de (localhost [127.0.0.1])
	by gg.genua.de (8.14.3/8.14.3) with ESMTP id o74IVPki016076;
	Wed, 4 Aug 2010 20:31:25 +0200 (CEST)
Received: (from localhost) by gg.genua.de (MSCAN) id
	4/gg.genua.de/smtp-gw/mscan; Wed Aug  4 20:31:25 2010
Date: Wed, 4 Aug 2010 20:27:43 +0200
From: Hans-Joerg Hoexer <tss-project@genua.de>
To: Takanori Watanabe <takawata@init-main.com>
Message-ID: <20100804182743.GA16796@modermoor.genua.de>
References: <201008040347.o743leeR046013@sana.init-main.com>
	<201008041039.o74AdfYO047937@sana.init-main.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201008041039.o74AdfYO047937@sana.init-main.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Mailman-Approved-At: Wed, 04 Aug 2010 18:38:51 +0000
Cc: tss-project@genua.de, freebsd-current@freebsd.org
Subject: Re: Driver tpm(4) and third party packages for trusted platform
 modules
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2010 18:27:52 -0000

Hi,

On Wed, Aug 04, 2010 at 07:39:41PM +0900, Takanori Watanabe wrote:
> In message <201008040347.o743leeR046013@sana.init-main.com>, wrote:
> >Quick review and hack:
> >
> >1.How about attaching it as acpi child driver?
> >
> >In some case, TPM may appear in ACPI namespace (with _HID) and
> >TPM spec defines ACPI method to handle TPM specific request.
> >
> >2. Is identify method needed? 
> >
> >Writing device hint will attach isa child driver, I think.
> >
> >3.Module build
> >
> >I don't know it is proper in TPM nature.

With respect to using a TPM as a PKCS#11 token for eg. ssh using a module
for the driver seems ok to me.

> Update my patch. Split bus attachment from main driver file
> (need to update sys/conf/files), add detach method for convinience, 
> and attach softc to cdev.si_drv1 .

many thanks for your feedback!

I will try to integrate your diff tomorrow.

Regards,
HJ.