From owner-cvs-src@FreeBSD.ORG Tue Nov 22 21:34:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1536B16A41F; Tue, 22 Nov 2005 21:34:27 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFC1243D4C; Tue, 22 Nov 2005 21:34:26 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jAMLYQgg085078; Tue, 22 Nov 2005 21:34:26 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jAMLYQAp085077; Tue, 22 Nov 2005 21:34:26 GMT (envelope-from marius) Message-Id: <200511222134.jAMLYQAp085077@repoman.freebsd.org> From: Marius Strobl Date: Tue, 22 Nov 2005 21:34:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sparc64/pci psycho.c psychoreg.h psychovar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2005 21:34:27 -0000 marius 2005-11-22 21:34:26 UTC FreeBSD src repository Modified files: sys/sparc64/pci psycho.c psychoreg.h psychovar.h Log: Some clean-up, style changes and changes that will reduce differences between this driver and other Host-PCI bridge drivers based on this one: - Make the code fit into 80 columns. - Make the code adhere style(9) (don't use function calls in initializers, use uintXX_t instead of u_intXX_t, add missing prototypes, ...). - Remove unused and superfluous struct declaration, softc member, casts, includes, etc. - Use FBSDID. - Sprinkle const. - Try to make comments and messages consistent in style throughout the driver. - Use convenience macros for the number of interrupts and ranges of the bridge. - Use __func__ instead of hardcoded function names in panic strings and error messages. Some of the hardcoded function names actually were outdated through moving code around. [1] - Rename softc members related to the PCI side of the bridge to sc_pci_* in order to make it clear which side of the bridge they refer to (so stuff like sc_bushandle vs. sc_bh is less confusing while reading the code). PR: 76052 [1] Revision Changes Path 1.54 +192 -197 src/sys/sparc64/pci/psycho.c 1.10 +34 -31 src/sys/sparc64/pci/psychoreg.h 1.13 +17 -18 src/sys/sparc64/pci/psychovar.h