From owner-p4-projects@FreeBSD.ORG Tue Feb 28 20:18:02 2012 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 501751065673; Tue, 28 Feb 2012 20:18:02 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12A991065670 for ; Tue, 28 Feb 2012 20:18:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:4f8:fff6::2d]) by mx1.freebsd.org (Postfix) with ESMTP id 005B78FC15 for ; Tue, 28 Feb 2012 20:18:02 +0000 (UTC) Received: from skunkworks.freebsd.org (localhost [127.0.0.1]) by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q1SKI1si070384 for ; Tue, 28 Feb 2012 20:18:01 GMT (envelope-from jhb@freebsd.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q1SKI1Q8070381 for perforce@freebsd.org; Tue, 28 Feb 2012 20:18:01 GMT (envelope-from jhb@freebsd.org) Date: Tue, 28 Feb 2012 20:18:01 GMT Message-Id: <201202282018.q1SKI1Q8070381@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to jhb@freebsd.org using -f From: John Baldwin To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 207047 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2012 20:18:02 -0000 http://p4web.freebsd.org/@@207047?ac=10 Change 207047 by jhb@jhb_jhbbsd on 2012/02/28 20:17:48 Don't create DMA tags on PCI busses behind a PCI-PCI bridge. Affected files ... .. //depot/projects/pci/sys/dev/pci/pci.c#28 edit Differences ... ==== //depot/projects/pci/sys/dev/pci/pci.c#28 (text+ko) ==== @@ -3175,15 +3175,18 @@ if (bootverbose) device_printf(dev, "domain=%d, physical bus=%d\n", domain, busno); - error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, PCI_DMA_BOUNDARY, - BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXSIZE, - BUS_SPACE_UNRESTRICTED, BUS_SPACE_MAXSIZE, 0, NULL, NULL, - &sc->sc_dma_tag); - if (error) - device_printf(dev, "Failed to create DMA tag: %d\n", error); - else - sc->sc_dma_tag_valid = 1; - + if (device_get_devclass(device_get_parent(device_get_parent(dev))) != + devclass_find("pci")) { + error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, + PCI_DMA_BOUNDARY, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, + NULL, NULL, BUS_SPACE_MAXSIZE, BUS_SPACE_UNRESTRICTED, + BUS_SPACE_MAXSIZE, 0, NULL, NULL, &sc->sc_dma_tag); + if (error) + device_printf(dev, "Failed to create DMA tag: %d\n", + error); + else + sc->sc_dma_tag_valid = 1; + } return (0); }