From owner-svn-src-all@freebsd.org Fri May 25 21:10:27 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BAE6EF479D; Fri, 25 May 2018 21:10:27 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B8A1748F4; Fri, 25 May 2018 21:10:26 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 572D79254; Fri, 25 May 2018 21:10:26 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 26791810; Fri, 25 May 2018 21:10:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id qxCvU6vuNK5R; Fri, 25 May 2018 21:10:22 +0000 (UTC) To: Brad Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com F183880B References: <201805091344.w49Dist5061908@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Subject: Re: svn commit: r333407 - head/share/mk Message-ID: <88989fda-4d0b-af16-8d08-28b6cdba0d34@FreeBSD.org> Date: Fri, 25 May 2018 14:10:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201805091344.w49Dist5061908@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="22b1Za7qULLbYDKqE6Ar9axKfiB0ikgYH" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 21:10:27 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --22b1Za7qULLbYDKqE6Ar9axKfiB0ikgYH Content-Type: multipart/mixed; boundary="natiugY9Vw2GDyLnvO066LNJBisE4afca"; protected-headers="v1" From: Bryan Drewery To: Brad Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <88989fda-4d0b-af16-8d08-28b6cdba0d34@FreeBSD.org> Subject: Re: svn commit: r333407 - head/share/mk References: <201805091344.w49Dist5061908@repo.freebsd.org> In-Reply-To: <201805091344.w49Dist5061908@repo.freebsd.org> --natiugY9Vw2GDyLnvO066LNJBisE4afca Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/9/2018 6:44 AM, Brad Davis wrote: > Author: brd > Date: Wed May 9 13:44:54 2018 > New Revision: 333407 > URL: https://svnweb.freebsd.org/changeset/base/333407 >=20 > Log: > Enable directory creation with FILESDIR. > =20 > This is part of packaging base work. > =20 > Reviewed by: will > Approved by: bapt (mentor), allanjude (mentor) > Differential Revision: https://reviews.freebsd.org/D15130 >=20 Please update share/mk/bsd.README too. I know I haven't been very responsive but it's partly because I'm still fundamentally against this feature. It's adding a mechanism to replace mtree without considering the whole picture and only binding it to FILES rather than a bsd.dirs.mk; It doesn't actually satisfy replacing mtree files since it only works if there is a FILESGROUP used (FILES must be non-empty). So what's the point? My major concern is added confusion. The creation of directories for installing is a pain point at work for developers but I don't think this is enough. I liked the idea of `install "-D"` but I know it's not efficient and had some implementation issues. More below... > Modified: > head/share/mk/bsd.files.mk > head/share/mk/bsd.own.mk >=20 > Modified: head/share/mk/bsd.files.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/share/mk/bsd.files.mk Wed May 9 12:25:23 2018 (r333406) > +++ head/share/mk/bsd.files.mk Wed May 9 13:44:54 2018 (r333407) > @@ -67,7 +67,7 @@ STAGE_AS_${file:T}=3D ${${group}NAME_${file:T}} > STAGE_DIR.${file:T}=3D ${STAGE_OBJTOP}${${group}DIR_${file:T}} > stage_as.${file:T}: ${file} > =20 > -installfiles-${group}: _${group}INS_${file:T} > +installfiles-${group}: installdirs-${group} _${group}INS_${file:T} > _${group}INS_${file:T}: ${file} > ${INSTALL} ${${group}TAG_ARGS} -o ${${group}OWN_${.ALLSRC:T}} \ > -g ${${group}GRP_${.ALLSRC:T}} -m ${${group}MODE_${.ALLSRC:T}} \ > @@ -77,10 +77,24 @@ _${group}INS_${file:T}: ${file} > _${group}FILES+=3D ${file} > .endif > .endfor > + > + > +installdirs-${group}: > + @echo installing dirs ${group}DIR ${${group}DIR} > +.for dir in ${${group}DIR} > +.if defined(NO_ROOT) > + ${INSTALL} ${${group}TAG_ARGS} -d ${DESTDIR}${dir} > +.else > + ${INSTALL} ${${group}TAG_ARGS} -d -o ${DIROWN} -g ${DIRGRP} \ > + -m ${DIRMODE} ${DESTDIR}${dir} I missed this before but the OWN/GRP/MODE usage needs to be per group just like the FILES group ones are above; it needs to be able to modify the permissions per group rather than only using the globals. > +.endif > +.endfor > + > + > .if !empty(_${group}FILES) > stage_files.${group}: ${_${group}FILES} > =20 > -installfiles-${group}: _${group}INS > +installfiles-${group}: installdirs-${group} _${group}INS > _${group}INS: ${_${group}FILES} > .if defined(${group}NAME) > ${INSTALL} ${${group}TAG_ARGS} -o ${${group}OWN} -g ${${group}GRP} \ >=20 > Modified: head/share/mk/bsd.own.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/share/mk/bsd.own.mk Wed May 9 12:25:23 2018 (r333406) > +++ head/share/mk/bsd.own.mk Wed May 9 13:44:54 2018 (r333407) > @@ -75,6 +75,13 @@ > # CONFMODE Configuration file mode. [644] > # > # > +# DIROWN Directory owner. [root] > +# > +# DIRGRP Directory group. [wheel] > +# > +# DIRMODE Directory mode. [755] > +# > +# > # DOCDIR Base path for system documentation (e.g. PSD, USD, > # handbook, FAQ etc.). [${SHAREDIR}/doc] > # > @@ -185,6 +192,10 @@ MANDIR?=3D ${SHAREDIR}/man/man > MANOWN?=3D ${SHAREOWN} > MANGRP?=3D ${SHAREGRP} > MANMODE?=3D ${NOBINMODE} > + > +DIROWN?=3D root > +DIRGRP?=3D wheel > +DIRMODE?=3D 755 > =20 > DOCDIR?=3D ${SHAREDIR}/doc > DOCOWN?=3D ${SHAREOWN} >=20 --=20 Regards, Bryan Drewery --natiugY9Vw2GDyLnvO066LNJBisE4afca-- --22b1Za7qULLbYDKqE6Ar9axKfiB0ikgYH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbCHu9AAoJEDXXcbtuRpfPjeQIAMnprIZUQb7S6H5z0Z1QItF+ pUqA3e/oO0ebn/hBRWRKAdUjo0NbR5mZ7dYQrAi/8OROxwkoZ5cSRraJYAuahE6a Poml4iTKBF+WSU4Brv88ImXMf03q3lVl1IFltPKaeukH+zyCiYbM14tqwtPAorZ6 iwFkLfgnEA4tofSBrs183XGNdAc/NZNTNXzI10yxmxZ8QsJRj7x81F7uVCSsRBUh ByTt2f/AqDm9a0Y9cm512UkY+SRzbIV8jghUhFFi8UtuSnKPgGOu5zTnyUZFaT14 bT2MXwM1+U/CwzllyauoDk59UyXG8Rd83O1fV2+fgYUYhU/PwoNMqeV6C3gTUwI= =7BFT -----END PGP SIGNATURE----- --22b1Za7qULLbYDKqE6Ar9axKfiB0ikgYH--