Date: Wed, 27 Jan 1999 13:43:53 -0800 (PST) From: Archie Cobbs <archie@whistle.com> To: dillon@apollo.backplane.com (Matthew Dillon) Cc: hackers@FreeBSD.ORG Subject: Re: Verification of bug in dev/pdq/pdq.c Message-ID: <199901272143.NAA15348@bubba.whistle.com> In-Reply-To: <199901271934.LAA47551@apollo.backplane.com> from Matthew Dillon at "Jan 27, 99 11:34:38 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon writes:
> cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing
> -prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no
> stdinc -I- -I. -I../.. -I../../../include -DKERNEL -include opt_global.h -elf
> ../../dev/pdq/pdq.c
> ../../dev/pdq/pdq.c: In function `pdq_process_received_data':
> ../../dev/pdq/pdq.c:767: warning: suggest parentheses around comparison in opera
> nd of |
>
> } else if (status.rxs_fsc == 0 | status.rxs_fsb_e == 1) {
> /* rx->rx_frame_status_errors++; */
>
>
> I presume the '|' instead of '||' is a bug. Second opinion?
It must be -- that makes no sense. Anyway, it doesn't matter
if you change it, because the result will be functionally identical.
-Archie
___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901272143.NAA15348>