From owner-cvs-src@FreeBSD.ORG  Mon Nov  3 19:08:39 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D32F816A4CF; Mon,  3 Nov 2003 19:08:39 -0800 (PST)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp
	[133.11.205.12])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CC30E43F75; Mon,  3 Nov 2003 19:08:37 -0800 (PST)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp [127.0.0.1])
	by is2.mh.itc.u-tokyo.ac.jp (Postfix) with ESMTP
	id 9D8613785A7; Tue,  4 Nov 2003 12:08:35 +0900 (JST)
Received: from mailhosting.itc.u-tokyo.ac.jp
	(IDENT:mirapoint@mailhosting.itc.u-tokyo.ac.jp [133.11.205.3])
	hA438Zxs018645;	Tue, 4 Nov 2003 12:08:35 +0900
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp
	[133.11.135.3])3.3.5-GR)	with ESMTP id ALJ10807;
	Tue, 4 Nov 2003 12:08:33 +0900 (JST)
Date: Tue, 04 Nov 2003 12:08:33 +0900
Message-ID: <ybsvfq07rv2.wl@ett.sat.t.u-tokyo.ac.jp>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: Brooks Davis <brooks@one-eyed-alien.net>
In-Reply-To: <20031103185552.GC31067@Odin.AC.HMC.Edu>
References: <200311031301.hA3D1Nuu035458@repoman.freebsd.org>
	<20031103185552.GC31067@Odin.AC.HMC.Edu>
User-Agent: Wanderlust/2.11.0 (Wonderwall) REMI/1.14.3 (Matsudai)
 FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.4
 (patch 8) (Honest Recruiter) (i386--freebsd)
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:
 #j7i14gu$jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oV
 uO^<vt/~051rCDM(`{rM~?{Okr,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
MIME-Version: 1.0 (generated by REMI 1.14.3 - "Matsudai")
Content-Type: text/plain; charset=US-ASCII
cc: Hidetoshi Shimokawa <simokawa@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/firewire if_fwe.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 03:08:40 -0000

At Mon, 3 Nov 2003 10:55:52 -0800,
Brooks Davis wrote:
> A better solution would be to move the printf below the if_initname call
> and use if_printf().  I dislike printfs that start with things like
> "if_fwe%d: ".

Yes. Since if_printf() is MFC'ed to 4-stable, there is no problem
to use them now. I'll fix them before MFC anyway.

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html