From owner-svn-src-all@freebsd.org Mon Dec 7 20:44:54 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A21E94B59FA; Mon, 7 Dec 2020 20:44:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cqb0Q44Qyz3plc; Mon, 7 Dec 2020 20:44:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 79FF07B96; Mon, 7 Dec 2020 20:44:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f178.google.com with SMTP id z11so4835339qkj.7; Mon, 07 Dec 2020 12:44:54 -0800 (PST) X-Gm-Message-State: AOAM532dumpZgeA8WzJhM0AJm+gmivp0HeQD6ZwD0gU6qXB7KHL8vYnl EcT3aoTVRJANIcNxj9SGbjNEreiJk3ZZG2KIQAM= X-Google-Smtp-Source: ABdhPJyzBEeDZEQ0DZbDXCJO+CMP9zpqZRsmaUHbQjeeeTOhNysMVkrXgTFMwdF46xnZ1RaXTh3EthkplqJaJQqczW8= X-Received: by 2002:a05:620a:14a:: with SMTP id e10mr9046512qkn.103.1607373894100; Mon, 07 Dec 2020 12:44:54 -0800 (PST) MIME-Version: 1.0 References: <202011250010.0AP0AtH3061986@repo.freebsd.org> <9f48b622-2596-f3c4-0aff-f0b57e8022ea@FreeBSD.org> <43f82b24-a1d0-8e48-a405-58e8bbda0c12@FreeBSD.org> <7506dfff-0d35-b71d-fedf-b9c0300205a2@FreeBSD.org> <63620a02-ba74-7728-385d-41f473d80afe@FreeBSD.org> In-Reply-To: <63620a02-ba74-7728-385d-41f473d80afe@FreeBSD.org> From: Kyle Evans Date: Mon, 7 Dec 2020 14:44:40 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat To: John Baldwin Cc: Steve Wills , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 20:44:54 -0000 On Mon, Dec 7, 2020 at 2:41 PM John Baldwin wrote: > > On 12/7/20 12:37 PM, Kyle Evans wrote: > > On Mon, Dec 7, 2020 at 2:36 PM John Baldwin wrote: > >> > >> qemu-user uses this flag? What on earth can it be using it for? > >> > > > > It was faithfully responding that it wasn't implemented to any > > target-application usage, apparently. :-) > > I mean, it is only a flag in the struct kinfo_file flags field. Even > if it is doing some kind of compat shim for kinfo_file it should just > copy the flags field across, not be checking any of the bits. Does it > try to log the type of a file descriptor in debug traces perhaps? > Apparently we were just that convinced we needed to enumerate the values we didn't have to touch, see: https://github.com/seanbruno/qemu-bsd-user/pull/150/files -> it was actually CRIOGET that we referenced for the sole purpose of declaring it unsupported.