From owner-cvs-all Tue Jun 20 11:11: 4 2000 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 4364037B519; Tue, 20 Jun 2000 11:10:52 -0700 (PDT) (envelope-from des@flood.ping.uio.no) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id UAA74204; Tue, 20 Jun 2000 20:10:36 +0200 (CEST) (envelope-from des@flood.ping.uio.no) To: Wes Peters Cc: Wes Peters , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch ftp.c References: <200006200532.WAA11992@freefall.freebsd.org> <394F9032.2123D32B@softweyr.com> From: Dag-Erling Smorgrav Date: 20 Jun 2000 20:10:36 +0200 In-Reply-To: Wes Peters's message of "Tue, 20 Jun 2000 09:39:30 -0600" Message-ID: Lines: 24 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Wes Peters writes: > Dag-Erling Smorgrav wrote: > > Wes Peters writes: > > > Reviewed by: silence > > Bollocks. Libfetch is under active development, and the fact that I > > haven't committed anything in three weeks doesn't mean it's abandoned. > When I contacted you five weeks ago, you agreed to review. Would you > like me to forward the email? I did not agree to review it, I agreed to consider it for inclusion in my code. A quick inspection showed that it duplicated significant portions of fetchStatFTP(), and I decided not to commit it as-is but to separate the relevant parts from fetchStatFTP() so they could be shared by both fetchStatFTP() and fetchListFTP(). I then set it aside since I was busy working on the HTTP code and the pkg_install patches. What's more, you made no further attempt to contact me after having submitted your patch, and construed my silence as approval even though you should have known (from mail I sent to -chat and -committers) that I was cut off from FreeBSD work due to an sshd misconfiguration. DES -- Dag-Erling Smorgrav - des@flood.ping.uio.no To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message