From owner-freebsd-ports@freebsd.org  Sun Jul 24 14:23:41 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AAA8BA379E
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Sun, 24 Jul 2016 14:23:41 +0000 (UTC) (envelope-from se@freebsd.org)
Received: from mailout08.t-online.de (mailout08.t-online.de [194.25.134.20])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mailout00.t-online.de",
 Issuer "TeleSec ServerPass DE-2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4242B1F33;
 Sun, 24 Jul 2016 14:23:40 +0000 (UTC) (envelope-from se@freebsd.org)
Received: from fwd03.aul.t-online.de (fwd03.aul.t-online.de [172.20.27.148])
 by mailout08.t-online.de (Postfix) with SMTP id F2FC741D6CCB;
 Sun, 24 Jul 2016 16:23:31 +0200 (CEST)
Received: from [192.168.119.34]
 (rAncLvZ-ohf8iA5WSLfuZ2N9nTpbmSNKD5alcN4vps3Opn-HRF3UPYDXh5MgaC9Z39@[84.154.108.212])
 by fwd03.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-SHA encrypted)
 esmtp id 1bRKJW-4ffvHs0; Sun, 24 Jul 2016 16:23:30 +0200
Subject: [FIXED] Re: portmaster --check-port-dbdir is broken for me
To: freebsd-ports@freebsd.org
References: <0b9a1969-b905-1b38-d13b-77cf79ceb4bc@toco-domains.de>
 <5236822d-88ab-96c1-15bc-30a700a3fd88@utanet.at>
From: Stefan Esser <se@freebsd.org>
Cc: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>, jakub_lach@mailplus.pl
Message-ID: <0cdb5c39-636b-9348-d292-8ca949dff583@freebsd.org>
Date: Sun, 24 Jul 2016 16:23:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <5236822d-88ab-96c1-15bc-30a700a3fd88@utanet.at>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-ID: rAncLvZ-ohf8iA5WSLfuZ2N9nTpbmSNKD5alcN4vps3Opn-HRF3UPYDXh5MgaC9Z39
X-TOI-MSGID: a0cc8131-bfd0-45ed-b91d-12d56561120a
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jul 2016 14:23:41 -0000

Am 21.07.2016 um 15:18 schrieb Walter Schwarzenfeld:
> Thorsten, after the remove of the  patch portmaster find the right files
> which are not installed, and nothing other.
> It seems is was the patch.

Sorry if my patch broke some of portmaster's functionality.

I had tested the behaviour of the loop with and without the patch
(you can repeat my test by adding "set -x" after the line reading

	echo "===>>> Building list of installed port names";  echo ''

and "set +x" before

	echo "===>>> Checking $port_dbdir"

The trace output is identical (except for the variable assignment
in all_pkgs_by_origin() for the patched file) and $unique_list is
identical throughout the loop.

BUT in case of the patched version, $unique_list is created in the
second process in the pipe, and lost when that process terminates.

This should be fixed in SVN rev. 419005.

Thanks for reporting and sorry for the incompete testing that I
had done for the initial patch.

Regards, STefan