From owner-dev-commits-src-all@freebsd.org Mon Feb 22 19:01:05 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE21854B16C; Mon, 22 Feb 2021 19:01:05 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dks3551zWz4Zy9; Mon, 22 Feb 2021 19:01:05 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 1A7C525ECA; Mon, 22 Feb 2021 19:01:05 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.45.21011103 Date: Mon, 22 Feb 2021 11:01:01 -0800 Subject: Re: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template From: Ravi Pokala To: Ed Maste , , , Message-ID: Thread-Topic: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template Thread-Index: AQHXCUtojqFRyqO3C0iT7EBCZKiAiw== References: <202102221531.11MFVxQU048362@gitrepo.freebsd.org> In-Reply-To: <202102221531.11MFVxQU048362@gitrepo.freebsd.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 19:01:05 -0000 -----Original Message----- From: on behalf of Ed Maste Date: 2021-02-22, Monday at 07:31 To: , , Subject: git: aa8ae5fe17eb - main - git hooks: add "Fixes" trailer to commit message template The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=aa8ae5fe17eb380b0f30f1641f17a0b3d83a68c3 commit aa8ae5fe17eb380b0f30f1641f17a0b3d83a68c3 Author: Ed Maste AuthorDate: 2021-02-20 18:49:31 +0000 Commit: Ed Maste CommitDate: 2021-02-22 15:29:56 +0000 git hooks: add "Fixes" trailer to commit message template A number of projects use "Fixes: " to identify a commit that is fixed by a given change. Adopt that convention. Differential Revision: https://reviews.freebsd.org/D28693 --- tools/tools/git/hooks/prepare-commit-msg | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/tools/git/hooks/prepare-commit-msg b/tools/tools/git/hooks/prepare-commit-msg index 4d1072700af0..761b4443cfd8 100755 --- a/tools/tools/git/hooks/prepare-commit-msg +++ b/tools/tools/git/hooks/prepare-commit-msg @@ -48,6 +48,7 @@ $(awk '1;/^#$/{exit}' $1) # Tested by: # Approved by: # Obtained from: +# Fixes: Hi Ed, To be clear, that's "${HASH} ${TITLE}" ; space-separated, not colon- or tab-separated? If that's the case, it would be clearer to say that it's the output of `git log --oneline' for the commit in question. (Interestingly, I can't seem to figure out how to get `git log --oneline' to print *only* the commit in question; I have to pipe through `grep -m1 ${HASH}'.) Thanks, Ravi (rpokala@) # MFC after: # MFH: # Relnotes: