From owner-svn-src-head@freebsd.org Mon Feb 10 19:54:37 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD16B24294A; Mon, 10 Feb 2020 19:54:37 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Gc7K0KWWz3y9b; Mon, 10 Feb 2020 19:54:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x341.google.com with SMTP id p17so608293wma.1; Mon, 10 Feb 2020 11:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GhwyB/4aIRQ9OHyFICs/51wvaZ/ls1p9U9ALaPiKCXU=; b=AabzPJ+JIDXtYK2+8s/yE9jgu/IZIovh/7Vd2O7iYd7iWNaIpTAb2G/nv2yPKK18Io /yFg/dDfrsbe1CIc2vDgZZZLrA0iDd/SXV30LqjrByGgItt/FRlCrEanpaM3uxQwye+2 TsyeUYF90s9E9o7IZ4jsa8q0H6bD98nwhhN7XNTVVPti3xkFrz+H+Nq9dhs35J7FMiRp N3nRh3qlm8rDqLa8r9ZnAcH9ppl+vmmhALeorTeRzArRkar8NE+Wzst9XWIYm+pBcR2h vAXw6JVoZalvEeNPqURU14TSIMlVBURGuxMVFlNONfeEtCrGj+/kJhg0sOgka286sbdo 1ctA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GhwyB/4aIRQ9OHyFICs/51wvaZ/ls1p9U9ALaPiKCXU=; b=P3SlnSOiqW4248+5p2TzUkg5xxyPcWVTjL+eHtlItT8KAMBVzhsWocpxbT6An5QGfh LxztE2loIxhTNEu2tVNiWDtakUwRJaS5YVLBk6v7a+e52SRVulvTbirKRxsWqjGtvvJE ItL/3JR+3JaeDnRMXyt1oWC/FhOC9JJNVOBwPAgIDSnO8ouU63eenJLScu4vZiZb8Hcy AIG2BLLTv6IQIoDWubGzGmPUOG6wMkB58eCfRMu/WryeEjzUa249KL+ijrFsp8n3NUaR KZnJ67P7ZNh7hfjF1ngeu+usM+JmkVcct6zGkB5Fuft3mWwPEsTpOh0vhNtVFmU7qg76 4Zqw== X-Gm-Message-State: APjAAAVyxoRrfCvM0Km1ghZdQzyvKFxrdsJY+zQjdFCt8zd9tPVm0gdz sapRt9cuaAyue2SPhNelK9br+SOr85/s++AnRAYBwQ== X-Google-Smtp-Source: APXvYqwQ5SKoEkF4R+RtIdqI/b44RBaRYEnRHb3EqT5UsU7ld/QBFaRSV/8YRC4RuQ/HDJKzp1Si2fc4ctmpmKScFRs= X-Received: by 2002:a1c:59c6:: with SMTP id n189mr595968wmb.178.1581364475241; Mon, 10 Feb 2020 11:54:35 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:6b02:0:0:0:0:0 with HTTP; Mon, 10 Feb 2020 11:54:34 -0800 (PST) In-Reply-To: <94dd2422-307b-9c06-ad84-d13d2e8a9fa4@FreeBSD.org> References: <202002010646.0116ktUk057327@repo.freebsd.org> <94dd2422-307b-9c06-ad84-d13d2e8a9fa4@FreeBSD.org> From: Mateusz Guzik Date: Mon, 10 Feb 2020 20:54:34 +0100 Message-ID: Subject: Re: svn commit: r357361 - in head/sys: kern sys ufs/ufs vm To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48Gc7K0KWWz3y9b X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=AabzPJ+J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (2.78), ipnet: 2a00:1450::/32(-2.47), asn: 15169(-1.72), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[1.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2020 19:54:37 -0000 On 2/3/20, John Baldwin wrote: > On 1/31/20 10:46 PM, Mateusz Guzik wrote: >> Author: mjg >> Date: Sat Feb 1 06:46:55 2020 >> New Revision: 357361 >> URL: https://svnweb.freebsd.org/changeset/base/357361 >> >> Log: >> vfs: replace VOP_MARKATIME with VOP_MMAPPED >> >> The routine is only provided by ufs and is only used on mmap and exec. >> >> Reviewed by: kib >> Differential Revision: https://reviews.freebsd.org/D23422 >> >> Modified: >> head/sys/kern/kern_exec.c >> head/sys/kern/vfs_subr.c >> head/sys/kern/vnode_if.src >> head/sys/sys/vnode.h >> head/sys/ufs/ufs/ufs_vnops.c >> head/sys/vm/vm_mmap.c >> >> Modified: head/sys/ufs/ufs/ufs_vnops.c >> ============================================================================== >> --- head/sys/ufs/ufs/ufs_vnops.c Sat Feb 1 06:41:44 2020 (r357360) >> +++ head/sys/ufs/ufs/ufs_vnops.c Sat Feb 1 06:46:55 2020 (r357361) >> @@ -108,7 +108,7 @@ static vop_getattr_t ufs_getattr; >> static vop_ioctl_t ufs_ioctl; >> static vop_link_t ufs_link; >> static int ufs_makeinode(int mode, struct vnode *, struct vnode **, >> struct componentname *, const char *); >> -static vop_markatime_t ufs_markatime; >> +static vop_mmapped_t ufs_mmapped; >> static vop_mkdir_t ufs_mkdir; >> static vop_mknod_t ufs_mknod; >> static vop_open_t ufs_open; >> @@ -676,19 +676,22 @@ out: >> } >> #endif /* UFS_ACL */ >> >> -/* >> - * Mark this file's access time for update for vfs_mark_atime(). This >> - * is called from execve() and mmap(). >> - */ > > Why remove this comment rather than update it? It is largely still > true and explains the purpose of the VOP (update the atime) which is > now no longer obvious from the name. > I don't think a fs-specific implementation of a VOP is the right place to state where it is called from. I would argue the name could be better as the execve bit is definitely not obvious, but interested parties can always grep. Finally, the function literally just updates atime so I don't think repeating this in the comment buys anything. -- Mateusz Guzik