From owner-cvs-sys  Mon Aug  4 01:01:27 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id BAA20918
          for cvs-sys-outgoing; Mon, 4 Aug 1997 01:01:27 -0700 (PDT)
Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id BAA20913;
          Mon, 4 Aug 1997 01:01:20 -0700 (PDT)
Received: (from root@localhost)
	by dyson.iquest.net (8.8.6/8.8.5) id DAA00278;
	Mon, 4 Aug 1997 03:01:09 -0500 (EST)
From: "John S. Dyson" <toor@dyson.iquest.net>
Message-Id: <199708040801.DAA00278@dyson.iquest.net>
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c
In-Reply-To: <14326.870681111@critter.dk.tfs.com> from Poul-Henning Kamp at "Aug 4, 97 09:51:51 am"
To: phk@dk.tfs.com (Poul-Henning Kamp)
Date: Mon, 4 Aug 1997 03:01:09 -0500 (EST)
Cc: dg@root.com, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
        cvs-sys@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL31 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> In message <199708040741.AAA08057@implode.root.com>, David Greenman writes:
> >>phk         1997/08/04 00:30:45 PDT
> >>
> >>  Modified files:
> >>    sys/ufs/ffs          ffs_alloc.c 
> >>  Log:
> >>  We got a couple of "map mismatch" panics from the following
> >>  code.  According to the crash dump, bpref is set to 445
> >>  and cgp->cg_nclusterblks is 444.  Hence in the for loop,
> >>  the test fails immediately but the following failure check
> >>  (got == cgp->cg_nclusterblks) doesn't trigger because got >
> >>  cgp->cg_nclusterblks.  This wreaks havoc in the code after that.
> >>  
> >>  Fix: Move one source bit to the left  :-)
> >>  
> >>  Noticed by:	Mike Hibler <mike@fast.cs.utah.edu>
> >>  Submitted by:	Kirk McKusick <mckusick@McKusick.COM>
> >
> >   Just so people aren't confused: the above patch has no affect on FreeBSD;
> >it's in an area of code that isn't even compiled.
> >
> >-DG
> >
> >David Greenman
> >Core-team/Principal Architect, The FreeBSD Project
> 
> True, should have said that.  This commit is just to keep us in sync
> with Kirk.
> 
I hope to re-enable the code (in our framework) someday.

John