From owner-freebsd-arch Tue Oct 2 1:52:58 2001 Delivered-To: freebsd-arch@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 0548737B40C for ; Tue, 2 Oct 2001 01:50:40 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id f928nbK89494; Tue, 2 Oct 2001 11:49:37 +0300 (EEST) (envelope-from ru) Date: Tue, 2 Oct 2001 11:49:36 +0300 From: Ruslan Ermilov To: Mark Murray Cc: arch@FreeBSD.ORG Subject: Re: [Patch] style.9 nit Message-ID: <20011002114936.L74839@sunbay.com> References: <200110011648.f91Gmgt25779@grimreaper.grondar.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200110011648.f91Gmgt25779@grimreaper.grondar.za>; from mark@grondar.za on Mon, Oct 01, 2001 at 05:48:42PM +0100 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Oct 01, 2001 at 05:48:42PM +0100, Mark Murray wrote: > Hi > > Any objections to this patch? > > It removes argument names from an example function prototype > to match a previously mentioned guideline about such names. > > eg: > > int foo(int bar); > > becomes > > int foo(int); > Hmm, what's wrong with this? : In header files visible to userland applications, prototypes that are : visible must use either protected names or no names with the types. It : is preferable to use protected names. E.g., use: : : void function(int); : : or: : : void function(int _fd); Your diff actually changes: int foo(int _bar); to int foo(int); which is acceptable prototype with "protected" names. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message