From owner-dev-commits-src-all@freebsd.org Fri Feb 19 22:14:28 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EFE58541ED1; Fri, 19 Feb 2021 22:14:28 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dj5Tc2V5Lz3QD2; Fri, 19 Feb 2021 22:14:28 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82f.google.com with SMTP id b24so5081757qtp.13; Fri, 19 Feb 2021 14:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UnUcC1a6oZm6R9l1FWjwSZ+jo6dNIC77yCUvmzK3s0I=; b=TetuRI/n7PXPeeRRxI+beBHjTKTBHHy0FLK2XFadX0teWCI/lcqSl8lZaVlO6FvLcE Lt91gFgjwnKSJvOCgcZnvBt8Y7ZMhpkN3pWg6lGDqR4S5zgIiuviS1QGTnpHxKJ+yEQo 4wsu8aNqNuuCqp5ey8surbBK7x3HlB9nkqm16TDnaW9jfEJbQ9dMmxIP0h+rQDGCd/Sh upHc4XSSiSgQgI/Gxk9G9oneT/fUEySCxDLfC09Z4wihNIFpN/WKnh4HlvZU2UcuyWjr PEswn1w/KtDp+uVI/yObFYsaTKsVlY4mLkVLJ2WYEeon2vsKeuqD99H/k2rnqOBSSMir QJQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=UnUcC1a6oZm6R9l1FWjwSZ+jo6dNIC77yCUvmzK3s0I=; b=Ly7590nw3JXysvnI9nbRO6e2bokqQ7zKtAG9iBukqMra5jk/Kwdb5JWtNaUSgipLAt 3uqofnkLDoP9tzvvqT8fMokXxVIfsP0W/nZcxYrUyL8zX13yDmV8dJaQtKH329uY0Kz4 7cqYlnsq4KyOT/tP8+pPAqPMUVeU8sGLhv2p2rQNm5c0rMU0YFEaBZRVettF2tiilQ3N DmbTmb6+Qz5uszdgn5ZQkINL6VpkAMH7QnOlmM02tMcFQYYQeYsWqAAe82w3uG49nQzZ DZ5y+I6FcZYQCgavy7VChHLh9f3xG6Fxw3gNVufG5vIPEcy39Y8WEhpOa1GRas2Nw/R5 zrIQ== X-Gm-Message-State: AOAM530sLIJfDuv4wAutMgdDHRwARxsfKbJeSgwM2zHtInyoPvF8EkC8 JxTRspCrfHqaWkNdeq15E25++cgRe3g= X-Google-Smtp-Source: ABdhPJzwYW90q9KiA0ZkWcJsWlOILepfFbSMOusWEB8F/N4QC2tYAA+AoSTHB2qt5vE/+mbup9SldQ== X-Received: by 2002:a05:622a:2c4:: with SMTP id a4mr11143093qtx.201.1613772867025; Fri, 19 Feb 2021 14:14:27 -0800 (PST) Received: from nuc ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id r190sm7419611qka.54.2021.02.19.14.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 14:14:26 -0800 (PST) Sender: Mark Johnston Date: Fri, 19 Feb 2021 17:14:27 -0500 From: Mark Johnston To: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f9544d03e89 - main - iflib: Fix detach of pseudo interfaces Message-ID: References: <202102192211.11JMBVWh076169@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202102192211.11JMBVWh076169@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4Dj5Tc2V5Lz3QD2 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=TetuRI/n; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::82f as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::82f:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::82f:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82f:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 22:14:29 -0000 On Fri, Feb 19, 2021 at 10:11:31PM +0000, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0f9544d03e89d180f94a7a84b110ec7d2b6c625a > > commit 0f9544d03e89d180f94a7a84b110ec7d2b6c625a > Author: Mark Johnston > AuthorDate: 2021-02-19 22:08:34 +0000 > Commit: Mark Johnston > CommitDate: 2021-02-19 22:10:41 +0000 > > iflib: Fix detach of pseudo interfaces > > In commit 38bfc6dee33b we added an IFDI_DETACH() call to > iflib_pseudo_deregister() since it looked like it was missing. One is > present in the error-handling path of iflib_pseudo_register(). However, > the detach actually comes from the DEVICE_DETACH() method for the > above-mentioned device_t, Sorry, missing context. A device is instantiated for each pseudo interface, I believe just to satisfy iflib's internal interfaces. > so now we're calling IFDI_DETACH() twice when > destroying a pseudo interface. > > Fix the problem by not calling IFDI_DETACH() from the device detach > routine. This way we can ensure that iflib de-initialization always > happens in a consistent order. It also ensures that you can't do silly > things like "devctl detach ", which would previously > detach the driver without tearing down the corresponding ifnet.