From owner-svn-ports-head@freebsd.org Sat Jan 6 15:15:26 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59A1FEBDB7E; Sat, 6 Jan 2018 15:15:26 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6311472E2D; Sat, 6 Jan 2018 15:15:25 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 2bcb7a7a TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sat, 6 Jan 2018 08:15:18 -0700 (MST) Content-Type: text/plain; charset=us-ascii; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: svn commit: r458000 - head/www/nginx From: Adam Weinberger In-Reply-To: <20180106134130.GA39725@FreeBSD.org> Date: Sat, 6 Jan 2018 08:15:16 -0700 Cc: Mathieu Arnold , v@fatpipi.com, Jochen Neumeister , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: References: <201801031933.w03JXLGa033758@repo.freebsd.org> <20180106134130.GA39725@FreeBSD.org> To: "Sergey A. Osokin" X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2018 15:15:26 -0000 > On 6 Jan, 2018, at 6:41, Sergey A. Osokin wrote: > > On Thu, Jan 04, 2018 at 08:30:55AM +0100, Mathieu Arnold wrote: >> Le 04/01/2018 ?? 02:56, Vanilla Hsu a ??crit : >>> auth-digest is not default module, so you don't need to bump >>> PORTREVISION. >> >> Yes you do. >> To quote >> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision >> : >> >> PORTREVISION must be increased each time a change is made to the >> port that changes the generated package in any way. That includes >> changes that only affect a package built with non-default options. > > I've tried to find a commit in doc area to better understand who and why > did this change. Another question is why this so important change > hasn't been discussed and why committers and community haven't been > notified > about that in advance. Hi Sergey, It's been policy for a long time now, a number of years at least. It does feel strange at first, but it really does benefit our users in the end. The reason we have to bump PORTREVISION for non-default options is the same reason we have to bump PORTREVISION for default options. When something changes, build scripts need to know to rebuild the package. There is simply no way for that to happen unless we tell them to. I know you're not a fan of forcing default option users to rebuild ports when their setup hasn't changed, but the other side of it is that we often force non-default option users to rebuild when THEIR setup hasn't changed. It works both ways, and it's just a consequence of our build paradigm. It has to happen though, every time. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org