From owner-svn-src-all@freebsd.org Mon Dec 16 01:37:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8331F1D4EE0; Mon, 16 Dec 2019 01:37:04 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47bkQm2tDnz4Bbd; Mon, 16 Dec 2019 01:37:04 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5E0521DF2E; Mon, 16 Dec 2019 01:37:04 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id xBG1b4iX084412; Mon, 16 Dec 2019 01:37:04 GMT (envelope-from kevans@FreeBSD.org) Received: (from kevans@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id xBG1b3En084409; Mon, 16 Dec 2019 01:37:03 GMT (envelope-from kevans@FreeBSD.org) Message-Id: <201912160137.xBG1b3En084409@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kevans set sender to kevans@FreeBSD.org using -f From: Kyle Evans Date: Mon, 16 Dec 2019 01:37:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r355793 - in head/sys: arm/versatile dev/gpio dev/hyperv/input dev/usb/input X-SVN-Group: head X-SVN-Commit-Author: kevans X-SVN-Commit-Paths: in head/sys: arm/versatile dev/gpio dev/hyperv/input dev/usb/input X-SVN-Commit-Revision: 355793 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 01:37:04 -0000 Author: kevans Date: Mon Dec 16 01:37:03 2019 New Revision: 355793 URL: https://svnweb.freebsd.org/changeset/base/355793 Log: kbd drivers: use kbdd_* indirection for diag invocation These invocations were directly calling enkbd_diag(), rather than indirection back through kbdd_diag/kbdsw. While they're functionally equivent, invoking kbdd_diag where feasible (i.e. not in a diag implementation) makes it easier to visually identify locking needs in these other drivers. Modified: head/sys/arm/versatile/pl050.c head/sys/dev/gpio/gpiokeys.c head/sys/dev/hyperv/input/hv_kbd.c head/sys/dev/usb/input/ukbd.c Modified: head/sys/arm/versatile/pl050.c ============================================================================== --- head/sys/arm/versatile/pl050.c Mon Dec 16 01:27:14 2019 (r355792) +++ head/sys/arm/versatile/pl050.c Mon Dec 16 01:37:03 2019 (r355793) @@ -717,7 +717,7 @@ pl050_kmi_attach(device_t dev) #endif if (bootverbose) { - genkbd_diag(kbd, bootverbose); + kbdd_diag(kbd, bootverbose); } kmi_attached = 1; return (0); Modified: head/sys/dev/gpio/gpiokeys.c ============================================================================== --- head/sys/dev/gpio/gpiokeys.c Mon Dec 16 01:27:14 2019 (r355792) +++ head/sys/dev/gpio/gpiokeys.c Mon Dec 16 01:37:03 2019 (r355793) @@ -432,7 +432,7 @@ gpiokeys_attach(device_t dev) #endif if (bootverbose) { - genkbd_diag(kbd, 1); + kbdd_diag(kbd, 1); } total_keys = 0; Modified: head/sys/dev/hyperv/input/hv_kbd.c ============================================================================== --- head/sys/dev/hyperv/input/hv_kbd.c Mon Dec 16 01:27:14 2019 (r355792) +++ head/sys/dev/hyperv/input/hv_kbd.c Mon Dec 16 01:37:03 2019 (r355793) @@ -535,7 +535,7 @@ hv_kbd_drv_attach(device_t dev) } #endif if (bootverbose) { - genkbd_diag(kbd, bootverbose); + kbdd_diag(kbd, bootverbose); } return (0); detach: Modified: head/sys/dev/usb/input/ukbd.c ============================================================================== --- head/sys/dev/usb/input/ukbd.c Mon Dec 16 01:27:14 2019 (r355792) +++ head/sys/dev/usb/input/ukbd.c Mon Dec 16 01:37:03 2019 (r355793) @@ -1369,7 +1369,7 @@ ukbd_attach(device_t dev) sc->sc_flags |= UKBD_FLAG_ATTACHED; if (bootverbose) { - genkbd_diag(kbd, bootverbose); + kbdd_diag(kbd, bootverbose); } #ifdef USB_DEBUG