Date: Thu, 14 Sep 2023 10:02:38 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Mark Millard <marklmi@yahoo.com> Cc: Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged Message-ID: <9A0C699C-78DA-4EB9-945D-A7C3B29EF31D@FreeBSD.org> In-Reply-To: <86F9198D-5B52-4B59-A44D-DA249643B864@yahoo.com> References: <86F9198D-5B52-4B59-A44D-DA249643B864.ref@yahoo.com> <86F9198D-5B52-4B59-A44D-DA249643B864@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Mark,
On 14 Sep 2023, at 7:37, Mark Millard wrote:
> This change leads the port net/py-libdnet to be broken:
>
> --- fw-pf.lo ---
> fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE'
> if (ioctl(fw->fd, DIOCGETRULE, &pcr) =3D=3D 0 &&
> ^
> fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE'
> if (ioctl(fw->fd, DIOCGETRULE, &pcr) =3D=3D 0 &&
> ^
> --- intf.lo ---
> for (cnt =3D 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {=
> ^
> intf.c:571:2: note: previous statement is here
> if (entry->intf_addr.addr_type =3D=3D ADDR_TYPE_IP &&
> ^
> --- fw-pf.lo ---
> fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE'
> if ((ret =3D ioctl(fw->fd, DIOCGETRULE, &pr)) < 0)
> ^
> 3 errors generated.
>
> That leads to:
>
> [00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 | py39-libdnet-=
1.13_4: Failed: build
> [00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1=
: Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed
>
The commit removed those ioctls because they=E2=80=99ve been superseded b=
y newer (nvlist-based) versions.
Ports are strongly advised to use libpfctl rather than trying to deal wit=
h nvlists themselves.
See https://lists.freebsd.org/archives/freebsd-pf/2023-April/000345.html =
for an example of what the ports will have to do. It=E2=80=99s generally =
a trivial change.
Best regards,
Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A0C699C-78DA-4EB9-945D-A7C3B29EF31D>