From owner-svn-src-head@FreeBSD.ORG  Fri Mar 14 02:15:23 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 71AC3BF8;
 Fri, 14 Mar 2014 02:15:23 +0000 (UTC)
Received: from felyko.com (felyko.com [IPv6:2607:f2f8:a528::3:1337:ca7])
 by mx1.freebsd.org (Postfix) with ESMTP id 5A0DBCFB;
 Fri, 14 Mar 2014 02:15:23 +0000 (UTC)
Received: from [IPv6:2601:9:8280:603:d81c:eb3d:730f:25bd] (unknown
 [IPv6:2601:9:8280:603:d81c:eb3d:730f:25bd])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by felyko.com (Postfix) with ESMTPSA id 6E39939843;
 Thu, 13 Mar 2014 19:15:22 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: svn commit: r262972 - head/sys/dev/usb/input
From: Rui Paulo <rpaulo@FreeBSD.org>
In-Reply-To: <201403100852.s2A8qUdC045704@svn.freebsd.org>
Date: Thu, 13 Mar 2014 19:15:26 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <D62898EB-F179-416B-A481-68604873477C@FreeBSD.org>
References: <201403100852.s2A8qUdC045704@svn.freebsd.org>
To: Hans Petter Selasky <hselasky@freebsd.org>
X-Mailer: Apple Mail (2.1874)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Mar 2014 02:15:23 -0000

On 10 Mar 2014, at 01:52, Hans Petter Selasky <hselasky@freebsd.org> =
wrote:

> Author: hselasky
> Date: Mon Mar 10 08:52:30 2014
> New Revision: 262972
> URL: http://svnweb.freebsd.org/changeset/base/262972
>=20
> Log:
>  Ignore USB keyboard driver calls from critical sections.
>=20
>  Reported by:	Oliver Pinter <oliver.pntr@gmail.com>
>  MFC after:	1 week
>=20
> Modified:
>  head/sys/dev/usb/input/ukbd.c
>=20
> Modified: head/sys/dev/usb/input/ukbd.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/dev/usb/input/ukbd.c	Mon Mar 10 06:41:48 2014	=
(r262971)
> +++ head/sys/dev/usb/input/ukbd.c	Mon Mar 10 08:52:30 2014	=
(r262972)
> @@ -1909,6 +1909,12 @@ ukbd_ioctl(keyboard_t *kbd, u_long cmd,=20
> 	int result;
>=20
> 	/*
> +	 * XXX Check of someone is calling us from a critical section:
> +	 */
> +	if (curthread->td_critnest !=3D 0)
> +		return (EDEADLK);

Shouldn't this panic?

--
Rui Paulo