From owner-svn-ports-all@FreeBSD.ORG Fri May 8 21:22:14 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D77AA3E7 for ; Fri, 8 May 2015 21:22:14 +0000 (UTC) Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com [209.85.213.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A464613A6 for ; Fri, 8 May 2015 21:22:14 +0000 (UTC) Received: by igbsb11 with SMTP id sb11so32273539igb.0 for ; Fri, 08 May 2015 14:22:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=RXrGmBAdSxKgO8mrmSKEFsbKQRy7qiM1vlgMsiqLnqs=; b=LIvBfv60eDFDd4/nR88a9oaOS9piWDMyp931wIuzRsZWPubjdxgYzqXwpULpFdsJbB L15mLWtp50ox/vFwtaWIAAs9KmxU7FcpCH1ldH/Yha0yFAznnmol+sOEa4WywKE4TMIN WuLbObrlu5sqx+aCmeqOzU3ZTWnsINJVXIP8iPHWWdmP1QMmlS8+O8gDm1GxCNZcIFuH OPiuIqOmaskSzyehLjZ01g43QKPu73mqxclO/Sp5HXWOaIhTY9WXu7vJfTtXOjO4l+uL AuThctQE8nerAPkQ2UpDVXDuZr7yZBT6ZcfCXvITu2F02ToDOqIta6MfrPkRVHaVEthW kM2Q== X-Gm-Message-State: ALoCoQnds40dT2YXrOmB3Q55XxnrrgJIdTXKRKEYTzUrobBLdGZS/b3cHdkOr7NWkipGQO7V+whp X-Received: by 10.107.170.226 with SMTP id g95mr20403ioj.2.1431119671279; Fri, 08 May 2015 14:14:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.220.229 with HTTP; Fri, 8 May 2015 14:13:50 -0700 (PDT) X-Originating-IP: [68.101.40.130] In-Reply-To: <554CDE6C.6000302@FreeBSD.org> References: <201505081305.t48D5ULi055835@svn.freebsd.org> <554CD6C9.5000708@FreeBSD.org> <554CDBE8.7020703@FreeBSD.org> <5AA4F2DD682E895BAD92C3A8@atuin.in.mat.cc> <554CDE6C.6000302@FreeBSD.org> From: "Philip M. Gollucci" Date: Fri, 8 May 2015 17:13:50 -0400 Message-ID: Subject: Re: svn commit: r385776 - in head/sysutils: . rubygem-hiera-file To: Bryan Drewery Cc: Mathieu Arnold , Sunpoet Po-Chuan Hsieh , Matthew Seaman , "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2015 21:22:15 -0000 Its also documented in the PBH to do what portlint says. I like the consistency but have no overall opinion. On Fri, May 8, 2015 at 12:03 PM, Bryan Drewery wrote: > On 5/8/2015 11:00 AM, Mathieu Arnold wrote: > > +--On 8 mai 2015 10:53:12 -0500 Bryan Drewery > wrote: > > |> > > |> % portlint -abct > > |> WARN: Makefile: Consider defining LICENSE. > > |> WARN: Makefile: "RUN_DEPENDS" has to appear earlier. > > |> 0 fatal errors and 2 warnings found. > > | > > | This rule serves no purpose. > > > > I don't really agree, from make's point of view, it does not, but from > the > > point of view of us all having to maintain a bunch of Makefiles, if the > > order of the group of fields is always consistent, it's easier to read. > > > > But it's not, and it's not possible to do so. Consider OPTION-based > DEPENDS. See www/nginx/Makefile as an example. This rule will never be > consistent and it's a pointless rule that serves only to annoy people. > > -- > Regards, > Bryan Drewery > > -- --------------------------------------------------------------------------------- Curb: Your ride is here 4096R/D1EAB94D 2081 E230 3001 6508 8847 1BBF A0A8 DB0F D1EA B94D Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. Director IT Operations, Curb What doesn't kill us can only make us stronger; Except it almost kills you.