Date: Thu, 02 Aug 2018 15:01:02 +0200 From: Alexander Leidinger <netchild@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r476193 - in head/audio/lame: . files Message-ID: <20180802150102.Horde.s6KtHYgokNv3W8TM8Bd94eE@webmail.leidinger.net> In-Reply-To: <muu5-ome2-wny@FreeBSD.org> References: <201808012001.w71K1Slh060704@repo.freebsd.org> <muu5-ome2-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format and has been PGP signed. --=_5VvpHrIF8RvaXBjq_rbK8In Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Jan Beich <jbeich@freebsd.org> (from Wed, 01 Aug 2018 22:35:49 +020= 0): > Alexander Leidinger <netchild@FreeBSD.org> writes: > >> Author: netchild >> Date: Wed Aug 1 20:01:27 2018 >> New Revision: 476193 >> URL: https://svnweb.freebsd.org/changeset/ports/476193 >> >> Log: >> Move patents text from the Makefile to a file. >> While I'm here, make it more an explanatory text than just a >> copy&paste from the previous comment of the Makefile. >> >> Requested by: portmgr (mat) > [...] >> +LICENSE_FILE_PATENTS=3D $(FILESDIR)/lame_patents.txt > > $(...) isn't consistent with the rest of the file. Ooops. > $ portlint -C > WARN: Makefile: [18]: use ${VARIABLE}, instead of $(VARIABLE). > FATAL: Makefile: LICENSE_NAME_PATENTS appears out-of-order. > FATAL: Makefile: LICENSE_FILE_PATENTS appears out-of-order. > FATAL: Makefile: order must be=20=20 >=20LICENSE/LICENSE_COMB/LICENSE_GROUPS(_\w+)?/LICENSE_NAME(_\w+)?/LICENSE_= TEXT(_\w+)?/LICENSE_FILE(_\w+)?/LICENSE_PERMS(_\w+)?/LICENSE_DISTFILES(_\w+= )?. > 3 fatal errors and 1 warning found. May I challenge the order? LICENSE shall be ordered alphabetically,=20=20 and=20then we mix the patent grouped parts... Looks strange to me. If=20=20 you=20look at the result after your patch, it goes to PATENTS, then LGPL=20= =20 then=20PATENTS again. For me the natural grouping is per license, so=20=20 first=20all the variables for the first license, then all for the=20=20 second.=20Alphabetical order is off course easy to implement in tools=20=20 like=20portlint, and easy so teach to maintainers, but for the Mk files=20= =20 it=20doesn't matter, and in my opinion we should change that to group=20=20 per=20license, as it is less context-switching from one license to=20=20 another=20for the person which looks at multi-license ports. Bye, Alexander. > Index: audio/lame/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- audio/lame/Makefile (revision 476196) > +++ audio/lame/Makefile (working copy) > @@ -12,10 +12,10 @@ COMMENT=3D Fast MP3 encoder kit > > LICENSE=3D LGPL20+ PATENTS > LICENSE_COMB=3D multi > +LICENSE_NAME_PATENTS=3D Intellectual Property Precaution > LICENSE_FILE_LGPL20+ =3D ${WRKSRC}/COPYING > -LICENSE_NAME_PATENTS=3D Intellectual Property Precaution > +LICENSE_FILE_PATENTS=3D ${FILESDIR}/lame_patents.txt > LICENSE_PERMS_PATENTS=3D dist-mirror dist-sell no-pkg-mirror=20=20 >=20no-pkg-sell auto-accept > -LICENSE_FILE_PATENTS=3D $(FILESDIR)/lame_patents.txt > > USES=3D gmake iconv libtool > USE_LDCONFIG=3D yes --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_5VvpHrIF8RvaXBjq_rbK8In Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJbYwCOAAoJEKrxQhqFIICESpYQAIEKNGdZYX892JRgQllGQhW5 LS/voJHIXmfHdZjWXyRph95HGPQ5rXkvNcQ2ruET7KQ2fcv6Ou+saxZs3JPVP0AR KER2yYQdTxrys5KOFUzq0fYbFo5HalGtb0QDfrXRRLFvWVPxh6nkpAIYiYr2g2Fj IbZblHAW81DH1J3bgVTe1LAj3mLSmqnNaAFx/n1qKjLfd6ZdypQOD7CHZ29Z1wKm KzN7WaUF0NS/VxCZzEU2A1tX8/hcHLnHj97X9QK4K8zOlK1GPiSzCnrOXxM6YJVL Z/nQrTP4IIAK5DVhVGj7q7KSGW08cWflBDcNc/yfzru6UNhl+hs3lxrsEjxEQ3DK fNXYX0fc8gkzJN3yGTNvaJOHzMzKXjV6CM1FiSpy8ZwgQ8JZmwhKE6obzYocWMwq rEa6ei9sx1Tl+dQmd33ZKZYQ25gRA1cEWCcSVjeGynBd4GEmnB6tYTNaNpTG4gR/ c5V9GClinoTZ9lsf255oNafleYtOxvrP2LeDwtA8HK44KqNatjWHmUB9oTWxUL5J 4fh7rGt8td0k//RgTnAfrIoEpbGei5Efn14VUhakGLi6K40peaACf1Thg8lyyFRw 6kf9V/2zdemYA647fcGjKd5EHUlLO7HykjvD2Vi0TH9/miOsITmCirYihlhF0LJR es0+WRER2wX5QNXU+P4i =UgH/ -----END PGP SIGNATURE----- --=_5VvpHrIF8RvaXBjq_rbK8In--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180802150102.Horde.s6KtHYgokNv3W8TM8Bd94eE>