From owner-svn-src-all@FreeBSD.ORG Sun Aug 5 21:50:41 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 613A8106566B; Sun, 5 Aug 2012 21:50:41 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by mx1.freebsd.org (Postfix) with ESMTP id 3D6AE8FC19; Sun, 5 Aug 2012 21:50:41 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.5/8.14.5) with ESMTP id q75LoZuO050934; Sun, 5 Aug 2012 14:50:35 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.5/8.14.5/Submit) id q75LoZ4W050933; Sun, 5 Aug 2012 14:50:35 -0700 (PDT) (envelope-from sgk) Date: Sun, 5 Aug 2012 14:50:34 -0700 From: Steve Kargl To: Dimitry Andric Message-ID: <20120805215034.GA50893@troutmask.apl.washington.edu> References: <201208051555.q75Ftbaa099801@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201208051555.q75Ftbaa099801@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r239071 - head/usr.bin/make X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2012 21:50:41 -0000 On Sun, Aug 05, 2012 at 03:55:37PM +0000, Dimitry Andric wrote: > Author: dim > Date: Sun Aug 5 15:55:36 2012 > New Revision: 239071 > URL: http://svn.freebsd.org/changeset/base/239071 > > Log: > In usr.bin/make/var.c, function ParseModifier(), initialize the 'error' > variable to NULL, to avoid using it uninitialized in certain cases. > > This fixes the following clang 3.2 warning: > > usr.bin/make/var.c:1770:10: error: variable 'error' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (vp->execute) { > ^~~~~~~~~~~ Please wrap your commit messages to less than 80 characters. In fact, including the clang warning does not add any valuable information and should be omitted. -- Steve