From owner-cvs-src@FreeBSD.ORG  Sun Jun 18 08:30:21 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 51AD116A47C;
	Sun, 18 Jun 2006 08:30:21 +0000 (UTC)
	(envelope-from maxim@macomnet.ru)
Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D9A6043D72;
	Sun, 18 Jun 2006 08:30:17 +0000 (GMT)
	(envelope-from maxim@macomnet.ru)
Received: from localhost (localhost.int.ru [127.0.0.1] (may be forged))
	by mp2.macomnet.net (8.13.7/8.13.3) with ESMTP id k5I8UG7v012763;
	Sun, 18 Jun 2006 12:30:16 +0400 (MSD)
	(envelope-from maxim@macomnet.ru)
Date: Sun, 18 Jun 2006 12:30:15 +0400 (MSD)
From: Maxim Konovalov <maxim@macomnet.ru>
To: Robert Watson <rwatson@FreeBSD.org>
In-Reply-To: <20060618091643.C67789@fledge.watson.org>
Message-ID: <20060618123005.C12737@mp2.macomnet.net>
References: <200606171732.k5HHWdl9086272@repoman.freebsd.org>
	<20060618013509.M67789@fledge.watson.org>
	<20060618101345.V10122@mp2.macomnet.net>
	<20060618091643.C67789@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Andre Oppermann <andre@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jun 2006 08:30:21 -0000

On Sun, 18 Jun 2006, 09:18+0100, Robert Watson wrote:

>
> On Sun, 18 Jun 2006, Maxim Konovalov wrote:
>
> > On Sun, 18 Jun 2006, 01:37+0100, Robert Watson wrote:
> >
> > > On Sat, 17 Jun 2006, Andre Oppermann wrote:
> > >
> > > >  Revision  Changes    Path
> > > >  1.299     +9 -6      src/sys/netinet/tcp_input.c
> > > >  1.87      +286 -255  src/sys/netinet/tcp_syncache.c
> > > >  1.130     +9 -6      src/sys/netinet/tcp_var.h
> > >
> > > This change appears to have broken world on all architectures by exposing
> > > the mutex data structure to usr.bin/netstat/inet.c via tcp_var.h.  I'm not
> > > quite sure what the "right" solution is, but if
> >
> > usr.bin/systat/netstat.c and usr.bin/netstat/inet.c
> > contrib/bsnmp/snmp_mibII/mibII_tcp.c as well.
> >
> > +#include <sys/callout.h> fixes the build.
>
> But is increasing the exposure of kernel data structures to user
> space apps the right fix, or decreasing them?  Andre fell into this
> trap precisely because of the leakage of kernel types into user
> space, and that's just one of several good reasons not to do it
> where it can possibly be avoided.

Agreed.

-- 
Maxim Konovalov